Bug 78526 - Convert RenderFrameSet to LayoutUnits in preparation for turning on subpixel layout
Summary: Convert RenderFrameSet to LayoutUnits in preparation for turning on subpixel ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Emil A Eklund
URL:
Keywords:
Depends on:
Blocks: 63567
  Show dependency tree / graph
 
Reported: 2012-02-13 13:42 PST by Emil A Eklund
Modified: 2012-02-15 23:04 PST (History)
5 users (show)

See Also:

Attachments
Patch (4.87 KB, patch)
2012-02-13 14:14 PST, Emil A Eklund 		no flags Details | Formatted Diff | Diff
Patch (4.98 KB, patch)
2012-02-15 17:01 PST, Emil A Eklund 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Emil A Eklund 2012-02-13 13:42:46 PST 
Convert RenderFrameSet to use LayoutUnits internally.
Comment 1 Emil A Eklund 2012-02-13 14:14:05 PST 
Created attachment 126834 [details]
Patch
Comment 2 Eric Seidel (no email) 2012-02-15 13:15:00 PST 
Comment on attachment 126834 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=126834&action=review

> Source/WebCore/rendering/RenderFrameSet.cpp:85
> +void RenderFrameSet::paintColumnBorder(const PaintInfo& paintInfo, const IntRect& borderRect)
>  {
> -    if (!paintInfo.rect.intersects(pixelSnappedIntRect(borderRect)))
> +    if (!paintInfo.rect.intersects(borderRect))

Why is this one ints?

> Source/WebCore/rendering/RenderFrameSet.cpp:103
>  void RenderFrameSet::paintRowBorder(const PaintInfo& paintInfo, const LayoutRect& borderRect)

Did you intentionally leave this one LayoutRects?

> Source/WebCore/rendering/RenderFrameSet.h:122
> +    void paintRowBorder(const PaintInfo&, const IntRect&);

This doesn't match the cpp side of your change.
Comment 3 Emil A Eklund 2012-02-15 16:10:23 PST 
(In reply to comment #2)
> (From update of attachment 126834 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=126834&action=review
> 
> > Source/WebCore/rendering/RenderFrameSet.cpp:85
> > +void RenderFrameSet::paintColumnBorder(const PaintInfo& paintInfo, const IntRect& borderRect)
> >  {
> > -    if (!paintInfo.rect.intersects(pixelSnappedIntRect(borderRect)))
> > +    if (!paintInfo.rect.intersects(borderRect))
> 
> Why is this one ints?

paintInfo.rect is in device pixels and represents what will be painted. As such we are keeping it in ints.

> 
> > Source/WebCore/rendering/RenderFrameSet.cpp:103
> >  void RenderFrameSet::paintRowBorder(const PaintInfo& paintInfo, const LayoutRect& borderRect)
> 
> Did you intentionally leave this one LayoutRects?

No, my bad. The .h file is correct.

> 
> > Source/WebCore/rendering/RenderFrameSet.h:122
> > +    void paintRowBorder(const PaintInfo&, const IntRect&);
> 
> This doesn't match the cpp side of your change.

I'll fix the cpp side.
Comment 4 Emil A Eklund 2012-02-15 17:01:35 PST 
Created attachment 127277 [details]
Patch
Comment 5 Eric Seidel (no email) 2012-02-15 17:13:10 PST 
Comment on attachment 127277 [details]
Patch

OK.
Comment 6 Emil A Eklund 2012-02-15 17:18:02 PST 
Thanks for catching the header/cpp mismatch, can't believe I missed that.
Comment 7 WebKit Review Bot 2012-02-15 23:04:32 PST 
Comment on attachment 127277 [details]
Patch

Clearing flags on attachment: 127277

Committed r107889: <http://trac.webkit.org/changeset/107889>
Comment 8 WebKit Review Bot 2012-02-15 23:04:38 PST 
All reviewed patches have been landed.  Closing bug.