RESOLVED FIXED 78526
Convert RenderFrameSet to LayoutUnits in preparation for turning on subpixel layout
https://bugs.webkit.org/show_bug.cgi?id=78526
Summary Convert RenderFrameSet to LayoutUnits in preparation for turning on subpixel ...
Emil A Eklund
Reported 2012-02-13 13:42:46 PST
Convert RenderFrameSet to use LayoutUnits internally.
Attachments
Patch (4.87 KB, patch)
2012-02-13 14:14 PST, Emil A Eklund
no flags
Patch (4.98 KB, patch)
2012-02-15 17:01 PST, Emil A Eklund
no flags
Emil A Eklund
Comment 1 2012-02-13 14:14:05 PST
Eric Seidel (no email)
Comment 2 2012-02-15 13:15:00 PST
Comment on attachment 126834 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=126834&action=review > Source/WebCore/rendering/RenderFrameSet.cpp:85 > +void RenderFrameSet::paintColumnBorder(const PaintInfo& paintInfo, const IntRect& borderRect) > { > - if (!paintInfo.rect.intersects(pixelSnappedIntRect(borderRect))) > + if (!paintInfo.rect.intersects(borderRect)) Why is this one ints? > Source/WebCore/rendering/RenderFrameSet.cpp:103 > void RenderFrameSet::paintRowBorder(const PaintInfo& paintInfo, const LayoutRect& borderRect) Did you intentionally leave this one LayoutRects? > Source/WebCore/rendering/RenderFrameSet.h:122 > + void paintRowBorder(const PaintInfo&, const IntRect&); This doesn't match the cpp side of your change.
Emil A Eklund
Comment 3 2012-02-15 16:10:23 PST
(In reply to comment #2) > (From update of attachment 126834 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=126834&action=review > > > Source/WebCore/rendering/RenderFrameSet.cpp:85 > > +void RenderFrameSet::paintColumnBorder(const PaintInfo& paintInfo, const IntRect& borderRect) > > { > > - if (!paintInfo.rect.intersects(pixelSnappedIntRect(borderRect))) > > + if (!paintInfo.rect.intersects(borderRect)) > > Why is this one ints? paintInfo.rect is in device pixels and represents what will be painted. As such we are keeping it in ints. > > > Source/WebCore/rendering/RenderFrameSet.cpp:103 > > void RenderFrameSet::paintRowBorder(const PaintInfo& paintInfo, const LayoutRect& borderRect) > > Did you intentionally leave this one LayoutRects? No, my bad. The .h file is correct. > > > Source/WebCore/rendering/RenderFrameSet.h:122 > > + void paintRowBorder(const PaintInfo&, const IntRect&); > > This doesn't match the cpp side of your change. I'll fix the cpp side.
Emil A Eklund
Comment 4 2012-02-15 17:01:35 PST
Eric Seidel (no email)
Comment 5 2012-02-15 17:13:10 PST
Comment on attachment 127277 [details] Patch OK.
Emil A Eklund
Comment 6 2012-02-15 17:18:02 PST
Thanks for catching the header/cpp mismatch, can't believe I missed that.
WebKit Review Bot
Comment 7 2012-02-15 23:04:32 PST
Comment on attachment 127277 [details] Patch Clearing flags on attachment: 127277 Committed r107889: <http://trac.webkit.org/changeset/107889>
WebKit Review Bot
Comment 8 2012-02-15 23:04:38 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.