Bug 78526 – Convert RenderFrameSet to LayoutUnits in preparation for turning on subpixel layout

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Emil A Eklund]

Convert RenderFrameSet to use LayoutUnits internally.

[Emil A Eklund]

Created attachment 126834 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 126834 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=126834&action=review

> Source/WebCore/rendering/RenderFrameSet.cpp:85
> +void RenderFrameSet::paintColumnBorder(const PaintInfo& paintInfo, const IntRect& borderRect)
>  {
> -    if (!paintInfo.rect.intersects(pixelSnappedIntRect(borderRect)))
> +    if (!paintInfo.rect.intersects(borderRect))

Why is this one ints?

> Source/WebCore/rendering/RenderFrameSet.cpp:103
>  void RenderFrameSet::paintRowBorder(const PaintInfo& paintInfo, const LayoutRect& borderRect)

Did you intentionally leave this one LayoutRects?

> Source/WebCore/rendering/RenderFrameSet.h:122
> +    void paintRowBorder(const PaintInfo&, const IntRect&);

This doesn't match the cpp side of your change.

[Emil A Eklund]

(In reply to comment #2)
> (From update of attachment 126834 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=126834&action=review
> 
> > Source/WebCore/rendering/RenderFrameSet.cpp:85
> > +void RenderFrameSet::paintColumnBorder(const PaintInfo& paintInfo, const IntRect& borderRect)
> >  {
> > -    if (!paintInfo.rect.intersects(pixelSnappedIntRect(borderRect)))
> > +    if (!paintInfo.rect.intersects(borderRect))
> 
> Why is this one ints?

paintInfo.rect is in device pixels and represents what will be painted. As such we are keeping it in ints.

> 
> > Source/WebCore/rendering/RenderFrameSet.cpp:103
> >  void RenderFrameSet::paintRowBorder(const PaintInfo& paintInfo, const LayoutRect& borderRect)
> 
> Did you intentionally leave this one LayoutRects?

No, my bad. The .h file is correct.

> 
> > Source/WebCore/rendering/RenderFrameSet.h:122
> > +    void paintRowBorder(const PaintInfo&, const IntRect&);
> 
> This doesn't match the cpp side of your change.

I'll fix the cpp side.

[Emil A Eklund]

Created attachment 127277 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 127277 [details]
Patch

OK.

[Emil A Eklund]

Thanks for catching the header/cpp mismatch, can't believe I missed that.

[WebKit Review Bot]

Comment on attachment 127277 [details]
Patch

Clearing flags on attachment: 127277

Committed r107889: <http://trac.webkit.org/changeset/107889>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.