Bug 78520 - Cleanup PageCache::canCachePageContainingThisFrame readability
Summary: Cleanup PageCache::canCachePageContainingThisFrame readability
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-13 13:00 PST by Brady Eidson
Modified: 2012-02-13 13:09 PST (History)
0 users

See Also:

Attachments
Patch v1 (3.64 KB, patch)
2012-02-13 13:02 PST, Brady Eidson 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2012-02-13 13:00:02 PST 
Cleanup PageCache::canCachePageContainingThisFrame

It's a giant if statement that keeps accessing the same member variables through getters.  Over and over.  And over.

Just store them locally to make it more readable.
Comment 1 Brady Eidson 2012-02-13 13:02:52 PST 
Created attachment 126810 [details]
Patch v1
Comment 2 Brady Eidson 2012-02-13 13:09:07 PST 
http://trac.webkit.org/changeset/107596