Bug 78519 - RenderTable::addChild() wrapInAnonymousSection is never !child->isPositioned()
Summary: RenderTable::addChild() wrapInAnonymousSection is never !child->isPositioned()
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tables (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-13 12:56 PST by Robert Hogan
Modified: 2022-09-10 06:59 PDT (History)
8 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Hogan 2012-02-13 12:56:26 PST 
void RenderTable::addChild(RenderObject* child, RenderObject* beforeChild)
{
    // Make sure we don't append things after :after-generated content if we have it.
    if (!beforeChild)
        beforeChild = afterPseudoElementRenderer();

    bool wrapInAnonymousSection = !child->isPositioned();

What was this initialization once for I wonder? The subsequent code means this initial value is not used anymore.
Comment 1 Julien Chaffraix 2012-07-27 16:20:39 PDT 
I wonder too, CSS 2.1 (section 17.2.1) doesn't special case the 'generate missing child wrappers' for out-of-flow elements.

It seems we didn't wrap out-of-flow elements at some point but this regressed. See bug 11363.
Comment 2 Ahmad Saleem 2022-09-10 06:59:08 PDT 
This code has been removed with this commit:

https://github.com/WebKit/WebKit/commit/69dba55f3051498c5717f2497b6b379cfdc02f05

Is this needed? Thanks!