Bug 78514 – isAppleWebKit() returns TRUE for WinCairo breaking various scripts

• Status: UNCONFIRMED
• Component: Tools / Tests

[David Delaune]

Hi,

In the \WebKit\Tools\Scripts\webkitdirs.pm perl module the function:

sub isAppleWebKit()
{
    return !(isQt() or isGtk() or isWx() or isChromium() or isEfl() or isWinCE() or isBlackBerry());
}

will always return true for the WinCairo branch. It could be fixed by adding a check for isWinCairo()

Best Wishes,
-David Delaune

[David Delaune]

Hi,

After some experimentation... it appears that this is a little more complicated than it first appeared. WinCairo currently depends on isAppleWebkit() returning true to build correctly. In order to fix this... there would need to be considerable changes made to the build scripts and project files.

Best Wishes,
-David Delaune

[Brent Fulgham]

I don't think we want this change.  The WinCairo port piggy-backs off of the Apple port, and tries to be as identical as possible to Apple's behavior.

I am able to run tests locally (as is the buildbot).  Can you provide more detail as to the errors you are seeing?