Bug 78511 - Update usage of LayoutUnits in RenderLayer
Summary: Update usage of LayoutUnits in RenderLayer
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Levi Weintraub
URL:
Keywords:
Depends on:
Blocks: 60318
  Show dependency tree / graph
 
Reported: 2012-02-13 11:44 PST by Levi Weintraub
Modified: 2012-02-14 13:18 PST (History)
5 users (show)

See Also:

Attachments
Patch (19.65 KB, patch)
2012-02-13 13:56 PST, Levi Weintraub 		no flags Details | Formatted Diff | Diff
Patch for landing (19.04 KB, patch)
2012-02-14 11:24 PST, Levi Weintraub 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Levi Weintraub 2012-02-13 11:44:17 PST 
RenderLayer hosts native controls that must be communicated with via integers, but are also nested and need to carry subpixel positioning data.
Comment 1 Levi Weintraub 2012-02-13 13:56:46 PST 
Created attachment 126825 [details]
Patch
Comment 2 Eric Seidel (no email) 2012-02-13 14:14:25 PST 
Simon should see this.
Comment 3 Simon Fraser (smfr) 2012-02-13 19:03:17 PST 
Comment on attachment 126825 [details]
Patch

I'll take your word for it.
Comment 4 Levi Weintraub 2012-02-14 11:24:21 PST 
Created attachment 127004 [details]
Patch for landing
Comment 5 Levi Weintraub 2012-02-14 11:27:19 PST 
(In reply to comment #3)
> (From update of attachment 126825 [details])
> I'll take your word for it.

Thanks for the review!
Comment 6 WebKit Review Bot 2012-02-14 13:14:11 PST 
The commit-queue encountered the following flaky tests while processing attachment 127004 [details]:

perf/array-reverse.html bug 78593 (author: ojan@chromium.org)
The commit-queue is continuing to process your patch.
Comment 7 WebKit Review Bot 2012-02-14 13:17:51 PST 
Comment on attachment 127004 [details]
Patch for landing

Clearing flags on attachment: 127004

Committed r107731: <http://trac.webkit.org/changeset/107731>
Comment 8 WebKit Review Bot 2012-02-14 13:18:07 PST 
All reviewed patches have been landed.  Closing bug.