Bug 78500 - Web Inspector: fire stylesheet changed event upon CSS modifications.
Summary: Web Inspector: fire stylesheet changed event upon CSS modifications.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-13 08:27 PST by Pavel Feldman
Modified: 2012-02-14 00:50 PST (History)
10 users (show)

See Also:


Attachments
Patch (43.37 KB, patch)
2012-02-13 08:28 PST, Pavel Feldman
yurys: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2012-02-13 08:27:21 PST
This is needed for syncing undo with the revision history.
Comment 1 Pavel Feldman 2012-02-13 08:28:52 PST
Created attachment 126776 [details]
Patch
Comment 2 Yury Semikhatsky 2012-02-13 09:07:05 PST
Comment on attachment 126776 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=126776&action=review

> Source/WebCore/inspector/InspectorStyleSheet.h:160
> +    struct Listener {

Should be class.

> Source/WebCore/inspector/front-end/CSSStyleModel.js:291
> +        this._pendingCommands.push(["CSSAgent.setStyleSheetText", majorChange]);

The name doesn't seem to be used, otherwise please introduce a class for the commands.

> LayoutTests/inspector/styles/styles-history.html:40
> +                    next();                

Remove the spaces.
Comment 3 Pavel Feldman 2012-02-14 00:50:32 PST
Committed r107683: <http://trac.webkit.org/changeset/107683>