Bug 78495 – Flakiness dashboard should show Linux ChromiumOS test results.

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Robert Flack]

The ChromiumOS waterfall at http://build.chromium.org/p/chromium.chromiumos/console links to the flakiness dashboard for failed Linux ChromiumOS tests. These tests use the same infrastructure as the Chromium tests and are for the most part a superset of the Chromium tests (Chromium tests + ChromiumOS tests). We should be able to view these test failures on the flakiness dashboard as with any other Chromium tests.

[Robert Flack]

Created attachment 126767 [details]
Patch to add Chromium.ChromiumOS master and relevant builders to flakiness dashboard.

[Ojan Vafai]

Comment on attachment 126767 [details]
Patch to add Chromium.ChromiumOS master and relevant builders to flakiness dashboard.

View in context: https://bugs.webkit.org/attachment.cgi?id=126767&action=review

Just a couple style nits.

This patch needs a ChangeLog file entry before it can be committed. I recommend uploading the patch using "Tools/Scripts/webkit-patch upload 78495 ".  That will automatically generate the ChangeLog entry for you and upload it here. Notably it will also set the r? flag for you which marks this as a patch needing review.

> Tools/TestResultServer/static-dashboards/builders.js:44
> +CHROMIUM_CHROMIUMOS_BUILDER_MASTER = new BuilderMaster('ChromiumChromiumOS', 'http://build.chromium.org/p/chromium.chromiumos/builders/');

Nit: The Chromium is clear from ChromiumOS, can we call these CHROMIUMOS_BUILDER_MASTER and 'ChromiumOS'?

> Tools/TestResultServer/static-dashboards/dashboard_base.js:181
> +            function() { return value in LAYOUT_TESTS_BUILDER_GROUPS ||
> +                                value in CHROMIUM_GTESTS_BUILDER_GROUPS; });

I'd either make this a single-line or break it up into normal function format like so:
function() {
    return foo ||
        bar;
}

[Robert Flack]

Created attachment 126792 [details]
Patch

[Robert Flack]

(In reply to comment #2)
> (From update of attachment 126767 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=126767&action=review
> 
> Just a couple style nits.
> 
> This patch needs a ChangeLog file entry before it can be committed. I recommend uploading the patch using "Tools/Scripts/webkit-patch upload 78495 ".  That will automatically generate the ChangeLog entry for you and upload it here. Notably it will also set the r? flag for you which marks this as a patch needing review.
> 
> > Tools/TestResultServer/static-dashboards/builders.js:44
> > +CHROMIUM_CHROMIUMOS_BUILDER_MASTER = new BuilderMaster('ChromiumChromiumOS', 'http://build.chromium.org/p/chromium.chromiumos/builders/');
> 
> Nit: The Chromium is clear from ChromiumOS, can we call these CHROMIUMOS_BUILDER_MASTER and 'ChromiumOS'?
> 

I changed the variable to CHROMIUMOS_BUILDER_MASTER. As for the master name, the master on test-results.appspot.com is called ChromiumChromiumOS, if I change this here I would have to map it back to ChromiumChromiumOS when building the request URL for test results. I think to change the actual master name would require many changes elsewhere.

> > Tools/TestResultServer/static-dashboards/dashboard_base.js:181
> > +            function() { return value in LAYOUT_TESTS_BUILDER_GROUPS ||
> > +                                value in CHROMIUM_GTESTS_BUILDER_GROUPS; });
> 
> I'd either make this a single-line or break it up into normal function format like so:
> function() {
>     return foo ||
>         bar;
> }

Done.

[Ojan Vafai]

Comment on attachment 126792 [details]
Patch

Thanks for doing this. I'm also setting cq+ so that this goes through the commit queue. For future reference, you need to set cq? to tell the reviewer you'd like it in the commit queue once it's been reviewed.

Once this patch is committed, it'll need to be pushed to the appengine server. I can do that later today.

[WebKit Review Bot]

Comment on attachment 126792 [details]
Patch

Clearing flags on attachment: 126792

Committed r107667: <http://trac.webkit.org/changeset/107667>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Ojan Vafai]

I've pushed this to appengine. Looks like it's working. http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40DEPS%20CrOS%20-%20chromium.org&testType=ui_tests