WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 78489
Add [CustomToJSObject] to interfaces which have custom toJS() and toV8()
https://bugs.webkit.org/show_bug.cgi?id=78489
Summary
Add [CustomToJSObject] to interfaces which have custom toJS() and toV8()
Kentaro Hara
Reported
2012-02-13 05:56:25 PST
The goal is to remove hard-coding in HasCustomToV8Implementation() in CodeGeneratorV8.pm, in the following steps: (1) Add [V8CustomToJSObject] to interfaces which have custom toV8() but do not have custom toJS(). (2) Replace [JSCustomToJS] with [JSCustomToJSObject] for interfaces which have custom toJS() but do not have custom toV8(). (3) Replace [JSCustomToJS] with [CustomToJSObject] for interfaces which have custom toV8() and toJS(). (4) Remove HasCustomToV8Implementation() from CodeGeneratorV8.pm. In this bug we fixes (3) and (4).
Attachments
Patch
(18.07 KB, patch)
2012-02-13 06:00 PST
,
Kentaro Hara
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Kentaro Hara
Comment 1
2012-02-13 06:00:04 PST
Created
attachment 126762
[details]
Patch
WebKit Review Bot
Comment 2
2012-02-13 16:43:15 PST
Comment on
attachment 126762
[details]
Patch Clearing flags on attachment: 126762 Committed
r107636
: <
http://trac.webkit.org/changeset/107636
>
WebKit Review Bot
Comment 3
2012-02-13 16:43:20 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug