Bug 78489 - Add [CustomToJSObject] to interfaces which have custom toJS() and toV8()
Summary: Add [CustomToJSObject] to interfaces which have custom toJS() and toV8()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks: 77393
  Show dependency treegraph
 
Reported: 2012-02-13 05:56 PST by Kentaro Hara
Modified: 2012-02-13 16:43 PST (History)
7 users (show)

See Also:


Attachments
Patch (18.07 KB, patch)
2012-02-13 06:00 PST, Kentaro Hara
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2012-02-13 05:56:25 PST
The goal is to remove hard-coding in HasCustomToV8Implementation() in CodeGeneratorV8.pm, in the following steps:

(1) Add [V8CustomToJSObject] to interfaces which have custom toV8() but do not have custom toJS().
(2) Replace [JSCustomToJS] with [JSCustomToJSObject] for interfaces which have custom toJS() but do not have custom toV8().
(3) Replace [JSCustomToJS] with [CustomToJSObject] for interfaces which have custom toV8() and toJS().
(4) Remove HasCustomToV8Implementation() from CodeGeneratorV8.pm.

In this bug we fixes (3) and (4).
Comment 1 Kentaro Hara 2012-02-13 06:00:04 PST
Created attachment 126762 [details]
Patch
Comment 2 WebKit Review Bot 2012-02-13 16:43:15 PST
Comment on attachment 126762 [details]
Patch

Clearing flags on attachment: 126762

Committed r107636: <http://trac.webkit.org/changeset/107636>
Comment 3 WebKit Review Bot 2012-02-13 16:43:20 PST
All reviewed patches have been landed.  Closing bug.