Bug 78457 - Move ENABLE(GAMEPAD) logic out of Navigator.h/cpp
Summary: Move ENABLE(GAMEPAD) logic out of Navigator.h/cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-12 22:00 PST by Adam Barth
Modified: 2012-02-12 23:03 PST (History)
4 users (show)

See Also:

Attachments
work in progress (8.14 KB, patch)
2012-02-12 22:00 PST, Adam Barth 		no flags Details | Formatted Diff | Diff
work in progress (12.41 KB, patch)
2012-02-12 22:02 PST, Adam Barth 		no flags Details | Formatted Diff | Diff
Patch (14.70 KB, patch)
2012-02-12 22:19 PST, Adam Barth 		no flags Details | Formatted Diff | Diff
Patch (19.08 KB, patch)
2012-02-12 22:27 PST, Adam Barth 		morrita: review+
abarth: commit-queue+
Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2012-02-12 22:00:16 PST 
Move ENABLE(GAMEPAD) logic out of Navigator.h/cpp
Comment 1 Adam Barth 2012-02-12 22:00:54 PST 
Created attachment 126713 [details]
work in progress
Comment 2 Adam Barth 2012-02-12 22:02:30 PST 
Created attachment 126714 [details]
work in progress
Comment 3 Adam Barth 2012-02-12 22:19:02 PST 
Created attachment 126716 [details]
Patch
Comment 4 Hajime Morrita 2012-02-12 22:23:35 PST 
Comment on attachment 126716 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=126716&action=review

Basically looks good. And thanks for cleaning up PageSupplement.

> Source/WebCore/ChangeLog:19
> +        * WebCore.gypi:

Don't miss WebCore.xcodeproj/project.pbxproj.
Comment 5 Adam Barth 2012-02-12 22:27:59 PST 
Created attachment 126718 [details]
Patch
Comment 6 Adam Barth 2012-02-12 23:03:22 PST 
Committed r107536: <http://trac.webkit.org/changeset/107536>