Bug 78418 - It should be possible to send all JSC debug logging to a file
Summary: It should be possible to send all JSC debug logging to a file
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2012-02-11 11:13 PST by Filip Pizlo
Modified: 2012-02-11 19:22 PST (History)
3 users (show)

See Also:


Attachments
the patch (210.57 KB, patch)
2012-02-11 11:28 PST, Filip Pizlo
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
the patch (210.67 KB, patch)
2012-02-11 12:24 PST, Filip Pizlo
no flags Details | Formatted Diff | Diff
the patch (209.56 KB, patch)
2012-02-11 13:45 PST, Filip Pizlo
sam: review+
Details | Formatted Diff | Diff
the patch (209.11 KB, patch)
2012-02-11 14:48 PST, Filip Pizlo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2012-02-11 11:13:58 PST
Patch forthcoming.
Comment 1 Filip Pizlo 2012-02-11 11:28:54 PST
Created attachment 126639 [details]
the patch
Comment 2 WebKit Review Bot 2012-02-11 11:34:56 PST
Attachment 126639 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1

Source/JavaScriptCore/wtf/DebugLogging.cpp:27:  You should add a blank line after implementation file's own header.  [build/include_order] [4]
Source/JavaScriptCore/interpreter/Interpreter.cpp:608:  More than one command on the same line  [whitespace/newline] [4]
Source/JavaScriptCore/interpreter/Interpreter.cpp:610:  More than one command on the same line  [whitespace/newline] [4]
Source/JavaScriptCore/interpreter/Interpreter.cpp:625:  More than one command on the same line  [whitespace/newline] [4]
Source/JavaScriptCore/interpreter/Interpreter.cpp:626:  More than one command on the same line  [whitespace/newline] [4]
Source/JavaScriptCore/interpreter/Interpreter.cpp:627:  More than one command on the same line  [whitespace/newline] [4]
Source/JavaScriptCore/interpreter/Interpreter.cpp:628:  More than one command on the same line  [whitespace/newline] [4]
Source/JavaScriptCore/interpreter/Interpreter.cpp:629:  More than one command on the same line  [whitespace/newline] [4]
Source/JavaScriptCore/interpreter/Interpreter.cpp:630:  More than one command on the same line  [whitespace/newline] [4]
Source/JavaScriptCore/bytecode/CodeBlock.cpp:1396:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 10 in 52 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 WebKit Review Bot 2012-02-11 11:55:07 PST
Comment on attachment 126639 [details]
the patch

Attachment 126639 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11505202
Comment 4 Early Warning System Bot 2012-02-11 11:55:43 PST
Comment on attachment 126639 [details]
the patch

Attachment 126639 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/11509162
Comment 5 Gyuyoung Kim 2012-02-11 11:58:26 PST
Comment on attachment 126639 [details]
the patch

Attachment 126639 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/11509161
Comment 6 Filip Pizlo 2012-02-11 12:24:06 PST
Created attachment 126640 [details]
the patch
Comment 7 WebKit Review Bot 2012-02-11 12:27:15 PST
Attachment 126640 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1

Source/JavaScriptCore/wtf/DebugLogging.cpp:27:  You should add a blank line after implementation file's own header.  [build/include_order] [4]
Source/JavaScriptCore/interpreter/Interpreter.cpp:608:  More than one command on the same line  [whitespace/newline] [4]
Source/JavaScriptCore/interpreter/Interpreter.cpp:610:  More than one command on the same line  [whitespace/newline] [4]
Source/JavaScriptCore/interpreter/Interpreter.cpp:625:  More than one command on the same line  [whitespace/newline] [4]
Source/JavaScriptCore/interpreter/Interpreter.cpp:626:  More than one command on the same line  [whitespace/newline] [4]
Source/JavaScriptCore/interpreter/Interpreter.cpp:627:  More than one command on the same line  [whitespace/newline] [4]
Source/JavaScriptCore/interpreter/Interpreter.cpp:628:  More than one command on the same line  [whitespace/newline] [4]
Source/JavaScriptCore/interpreter/Interpreter.cpp:629:  More than one command on the same line  [whitespace/newline] [4]
Source/JavaScriptCore/interpreter/Interpreter.cpp:630:  More than one command on the same line  [whitespace/newline] [4]
Source/JavaScriptCore/bytecode/CodeBlock.cpp:1396:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 10 in 52 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 Filip Pizlo 2012-02-11 13:45:38 PST
Created attachment 126644 [details]
the patch

- Fixing build

- As per chat with Sam, changed the name from "debug logging" to "data log".  "debugPrintf" becomes "dataLog", "debugFile" becomes "dataFile", and "DebugLogging.h" becomes "DataLog.h".
Comment 9 Filip Pizlo 2012-02-11 13:49:27 PST
Going to wait on EWS for this patch, since it's big and juicy.
Comment 10 Filip Pizlo 2012-02-11 14:48:11 PST
Created attachment 126649 [details]
the patch

Rebased patch, putting up for EWS.
Comment 11 WebKit Review Bot 2012-02-11 14:52:22 PST
Attachment 126649 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1

Source/JavaScriptCore/profiler/ProfileNode.cpp:35:  Alphabetical sorting problem.  [build/include_order] [4]
Source/JavaScriptCore/interpreter/Interpreter.cpp:608:  More than one command on the same line  [whitespace/newline] [4]
Source/JavaScriptCore/interpreter/Interpreter.cpp:610:  More than one command on the same line  [whitespace/newline] [4]
Source/JavaScriptCore/interpreter/Interpreter.cpp:625:  More than one command on the same line  [whitespace/newline] [4]
Source/JavaScriptCore/interpreter/Interpreter.cpp:626:  More than one command on the same line  [whitespace/newline] [4]
Source/JavaScriptCore/interpreter/Interpreter.cpp:627:  More than one command on the same line  [whitespace/newline] [4]
Source/JavaScriptCore/interpreter/Interpreter.cpp:628:  More than one command on the same line  [whitespace/newline] [4]
Source/JavaScriptCore/interpreter/Interpreter.cpp:629:  More than one command on the same line  [whitespace/newline] [4]
Source/JavaScriptCore/interpreter/Interpreter.cpp:630:  More than one command on the same line  [whitespace/newline] [4]
Source/JavaScriptCore/bytecode/CodeBlock.cpp:1396:  More than one command on the same line  [whitespace/newline] [4]
Source/JavaScriptCore/wtf/DataLog.cpp:27:  You should add a blank line after implementation file's own header.  [build/include_order] [4]
Total errors found: 11 in 53 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 12 Filip Pizlo 2012-02-11 19:20:17 PST
OK, it looks like the bots are as green as they're going to get.
Comment 13 Filip Pizlo 2012-02-11 19:22:17 PST
Landed in http://trac.webkit.org/changeset/107499
Comment 14 Filip Pizlo 2012-02-11 19:22:47 PST
<rdar://problem/10849720>