...to a global HashMap.
Created attachment 126620 [details] patch
Comment on attachment 126620 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=126620&action=review r=me with one fix: > Source/WebCore/css/StylePropertySet.cpp:49 > +static PropertySetCSSOMWrapperMap* propertySetCSSOMWrapperMap; This pointer needs to be explicitly initialized. Also, a common pattern in WebKit is to write these like so: static PropertySetCSSOMWrapperMap& propertySetCSSOMWrapperMap() { DEFINE_STATIC_LOCAL(PropertySetCSSOMWrapperMap, derp, ()); return derp; }
(In reply to comment #2) > (From update of attachment 126620 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=126620&action=review > > r=me with one fix: > > > Source/WebCore/css/StylePropertySet.cpp:49 > > +static PropertySetCSSOMWrapperMap* propertySetCSSOMWrapperMap; > > This pointer needs to be explicitly initialized. Disregard this cool story, bro. TIL that static globals are zero-initialized..
http://trac.webkit.org/changeset/107474 The pattern looks nicer so I did it anyway.