Bug 78405 – Plugins in iframes do not respect iframe shims from out of the iframe

• Status: RESOLVED
• Resolution: WONTFIX
• Component: Plug-ins

[Cem Kocagil]

Iframe shims work when the plugin and the obscuring iframe are in the same document, but not in some other cases. There's test case at Chrome's bug tracker: http://code.google.com/p/chromium/issues/detail?id=107431

[Cem Kocagil]

Created attachment 126615 [details]
Possible fix, one that might not have a good performance (needs profiling)

[WebKit Review Bot]

Attachment 126615 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/plugins/IFrameShimSupport.c..." exit_code: 1

Source/WebCore/plugins/IFrameShimSupport.cpp:149:  Use 0 instead of NULL.  [readability/null] [5]
Source/WebCore/plugins/IFrameShimSupport.cpp:187:  Declaration has space between type name and * in Widget *parentWidget  [whitespace/declaration] [3]
Total errors found: 2 in 1 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Cem Kocagil]

Created attachment 126616 [details]
Patch

[Robert Hogan]

Fixing the shim tests should be a blocker to any future changes to this code I think:

https://bugs.webkit.org/show_bug.cgi?id=3778#c16

You should also take a look at the patch there to see if using layers can help with this issue.

[Alexey Proskuryakov]

Mass closing plug-in bugs, as plug-in support has been removed from WebKit.

Please comment and/or reopen if this still affects WebKit in some way.