Bug 78370 - [chromium] compositing/rubberbanding tests failing
Summary: [chromium] compositing/rubberbanding tests failing
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: asvitkine
Depends on:
Reported: 2012-02-10 12:09 PST by Tony Chang
Modified: 2012-02-16 16:50 PST (History)
3 users (show)

See Also:

Patch (4.77 KB, patch)
2012-02-16 08:47 PST, asvitkine
no flags Details | Formatted Diff | Diff
Patch (15.73 KB, patch)
2012-02-16 11:18 PST, asvitkine
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Tony Chang 2012-02-10 12:09:29 PST
James can you take a look?  I'm going to mark the tests as failing for now.
Comment 2 Tony Chang 2012-02-10 12:12:27 PST
See also bug 78008.
Comment 3 asvitkine 2012-02-13 15:37:44 PST
Looking at the flaky runs of green/non-green results, the non-green results have tiny pixel differences in the rubber band gradients only.

Is that a known cause of flakyness with the compositing path? It seems the non-compositing rubber-banding tests don't have this flakyness in the gradients.

And then there's the more recent regression that just causes them to fail all the time due to not pattern/gradient area being drawn at all...
Comment 4 asvitkine 2012-02-16 07:06:56 PST
Pretty sure it's the mock scrollbars change. Rubber-band overhang painting is done by ScrollbarThemeChromiumMac.mm, while the mock scrollbar changes replaces this by ScrollbarThemeMock.
Comment 5 asvitkine 2012-02-16 08:47:02 PST
Created attachment 127389 [details]
Comment 6 James Robinson 2012-02-16 10:52:33 PST
Comment on attachment 127389 [details]

If you want these specific tests to not use mock scrollbars, then just call window.internals.settings.setMockScrollbarsEnabled(false) in the tests
Comment 7 asvitkine 2012-02-16 11:18:17 PST
Created attachment 127415 [details]
Comment 8 asvitkine 2012-02-16 11:19:03 PST
Comment on attachment 127415 [details]

New patch that just changes the tests to disable mock scrollbars.
Comment 9 James Robinson 2012-02-16 11:19:27 PST
Comment on attachment 127415 [details]

Comment 10 WebKit Review Bot 2012-02-16 16:49:58 PST
Comment on attachment 127415 [details]

Clearing flags on attachment: 127415

Committed r108000: <http://trac.webkit.org/changeset/108000>
Comment 11 WebKit Review Bot 2012-02-16 16:50:07 PST
All reviewed patches have been landed.  Closing bug.