Bug 78362 - Web Inspector: add filtering by class name in heap profiler
Summary: Web Inspector: add filtering by class name in heap profiler
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 78411
  Show dependency tree / graph
 
Reported: 2012-02-10 09:18 PST by Alexei Filippov
Modified: 2012-02-13 06:33 PST (History)
11 users (show)

See Also:

Attachments
Screenshot (91.31 KB, image/png)
2012-02-10 09:19 PST, Alexei Filippov 		no flags Details
Patch (6.98 KB, patch)
2012-02-10 09:27 PST, Alexei Filippov 		no flags Details | Formatted Diff | Diff
Patch (6.02 KB, patch)
2012-02-13 02:33 PST, Alexei Filippov 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexei Filippov 2012-02-10 09:18:26 PST 
$subj
Comment 1 Alexei Filippov 2012-02-10 09:19:01 PST 
Created attachment 126523 [details]
Screenshot
Comment 2 Alexei Filippov 2012-02-10 09:27:48 PST 
Created attachment 126524 [details]
Patch
Comment 3 Ilya Tikhonovsky 2012-02-13 00:50:45 PST 
looks good to me
Comment 4 Yury Semikhatsky 2012-02-13 01:09:22 PST 
Comment on attachment 126524 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=126524&action=review

> Source/WebCore/inspector/front-end/DetailedHeapshotView.js:221
> +        object: { title: WebInspector.UIString("Constructor"), disclosure: true, sort: "ascending", sortable: true },

Why do you need to change sorting order?
Comment 5 Alexei Filippov 2012-02-13 02:33:49 PST 
Created attachment 126738 [details]
Patch
Comment 6 Alexei Filippov 2012-02-13 02:35:11 PST 
Changed the sorting back as we agreed.
Comment 7 WebKit Review Bot 2012-02-13 06:33:45 PST 
Comment on attachment 126738 [details]
Patch

Clearing flags on attachment: 126738

Committed r107568: <http://trac.webkit.org/changeset/107568>
Comment 8 WebKit Review Bot 2012-02-13 06:33:51 PST 
All reviewed patches have been landed.  Closing bug.