RESOLVED FIXED Bug 78362
Web Inspector: add filtering by class name in heap profiler 
https://bugs.webkit.org/show_bug.cgi?id=78362
Summary Web Inspector: add filtering by class name in heap profiler
Alexei Filippov
Reported 2012-02-10 09:18:26 PST
$subj
Attachments
Screenshot (91.31 KB, image/png)
2012-02-10 09:19 PST, Alexei Filippov 		no flags
Details
Patch (6.98 KB, patch)
2012-02-10 09:27 PST, Alexei Filippov 		no flags
DetailsFormatted DiffDiff
Patch (6.02 KB, patch)
2012-02-13 02:33 PST, Alexei Filippov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alexei Filippov
Comment 1 2012-02-10 09:19:01 PST
Created attachment 126523 [details] Screenshot
Alexei Filippov
Comment 2 2012-02-10 09:27:48 PST
Created attachment 126524 [details] Patch
Ilya Tikhonovsky
Comment 3 2012-02-13 00:50:45 PST
looks good to me
Yury Semikhatsky
Comment 4 2012-02-13 01:09:22 PST
Comment on attachment 126524 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=126524&action=review > Source/WebCore/inspector/front-end/DetailedHeapshotView.js:221 > + object: { title: WebInspector.UIString("Constructor"), disclosure: true, sort: "ascending", sortable: true }, Why do you need to change sorting order?
Alexei Filippov
Comment 5 2012-02-13 02:33:49 PST
Created attachment 126738 [details] Patch
Alexei Filippov
Comment 6 2012-02-13 02:35:11 PST
Changed the sorting back as we agreed.
WebKit Review Bot
Comment 7 2012-02-13 06:33:45 PST
Comment on attachment 126738 [details] Patch Clearing flags on attachment: 126738 Committed r107568: <http://trac.webkit.org/changeset/107568>
WebKit Review Bot
Comment 8 2012-02-13 06:33:51 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.