Bug 78359 - [chromium] Remove obsolete zoom animation pathway.
Summary: [chromium] Remove obsolete zoom animation pathway.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: W. James MacLean
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-10 07:22 PST by W. James MacLean
Modified: 2012-02-13 20:42 PST (History)
4 users (show)

See Also:


Attachments
Patch (22.88 KB, patch)
2012-02-10 07:25 PST, W. James MacLean
no flags Details | Formatted Diff | Diff
Patch (22.69 KB, patch)
2012-02-10 14:09 PST, W. James MacLean
no flags Details | Formatted Diff | Diff
Patch (22.80 KB, patch)
2012-02-13 05:46 PST, W. James MacLean
no flags Details | Formatted Diff | Diff
Patch for landing (24.51 KB, patch)
2012-02-13 10:36 PST, W. James MacLean
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description W. James MacLean 2012-02-10 07:22:49 PST
[chromium] Remove obsolete zoom animation pathway.
Comment 1 W. James MacLean 2012-02-10 07:25:33 PST
Created attachment 126514 [details]
Patch
Comment 2 W. James MacLean 2012-02-10 07:26:45 PST
Removes dead code from the now obsolete pathway for zoom animation. Includes removal of unused functions from testing/Internals*.
Comment 3 WebKit Review Bot 2012-02-10 09:23:45 PST
Comment on attachment 126514 [details]
Patch

Attachment 126514 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11473690

New failing tests:
fast/dom/Range/scale-page-client-rects.html
fast/events/page-scaled-mouse-click-iframe.html
fast/frames/iframe-double-scale-contents.html
compositing/geometry/fixed-position-transform-composited-page-scale.html
fast/dom/window-inner-size-scaling.html
http/tests/inspector/inspect-element.html
fast/dom/Element/scale-page-bounding-client-rect.html
fast/events/scale-and-scroll-window.html
compositing/geometry/fixed-position-iframe-composited-page-scale.html
fast/events/scroll-in-scaled-page-with-overflow-hidden.html
fast/events/page-scaled-mouse-click.html
fast/events/scale-and-scroll-iframe-body.html
fast/dom/iframe-inner-size-scaling.html
compositing/scaling/tiled-layer-recursion.html
fast/repaint/background-scaling.html
compositing/geometry/fixed-position-composited-page-scale.html
fast/events/scale-and-scroll-body.html
accessibility/aria-describedby-on-input.html
fast/events/touch/page-scaled-touch-gesture-click.html
fast/events/scale-and-scroll-iframe-window.html
fast/frames/frame-set-scaling-hit.html
compositing/geometry/fixed-position-iframe-composited-page-scale-down.html
fast/frames/frame-set-rotation-hit.html
compositing/geometry/fixed-position-composited-page-scale-down.html
fast/dom/Element/scale-page-client-rects.html
compositing/geometry/fixed-position-transform-composited-page-scale-down.html
fast/dom/Range/scale-page-bounding-client-rect.html
fast/repaint/scale-page-shrink.html
Comment 4 W. James MacLean 2012-02-10 09:42:44 PST
(In reply to comment #3)
> (From update of attachment 126514 [details])
> Attachment 126514 [details] did not pass chromium-ews (chromium-xvfb):
> Output: http://queues.webkit.org/results/11473690
> 
> New failing tests:
> fast/dom/Range/scale-page-client-rects.html
> fast/events/page-scaled-mouse-click-iframe.html
> fast/frames/iframe-double-scale-contents.html
> compositing/geometry/fixed-position-transform-composited-page-scale.html
> fast/dom/window-inner-size-scaling.html
> http/tests/inspector/inspect-element.html
> fast/dom/Element/scale-page-bounding-client-rect.html
> fast/events/scale-and-scroll-window.html
> compositing/geometry/fixed-position-iframe-composited-page-scale.html
> fast/events/scroll-in-scaled-page-with-overflow-hidden.html
> fast/events/page-scaled-mouse-click.html
> fast/events/scale-and-scroll-iframe-body.html
> fast/dom/iframe-inner-size-scaling.html
> compositing/scaling/tiled-layer-recursion.html
> fast/repaint/background-scaling.html
> compositing/geometry/fixed-position-composited-page-scale.html
> fast/events/scale-and-scroll-body.html
> accessibility/aria-describedby-on-input.html
> fast/events/touch/page-scaled-touch-gesture-click.html
> fast/events/scale-and-scroll-iframe-window.html
> fast/frames/frame-set-scaling-hit.html
> compositing/geometry/fixed-position-iframe-composited-page-scale-down.html
> fast/frames/frame-set-rotation-hit.html
> compositing/geometry/fixed-position-composited-page-scale-down.html
> fast/dom/Element/scale-page-client-rects.html
> compositing/geometry/fixed-position-transform-composited-page-scale-down.html
> fast/dom/Range/scale-page-bounding-client-rect.html
> fast/repaint/scale-page-shrink.html

The removed pathway should have been inactive for quite a long time, so I'm not sure (could be wrong) that these failures are related to this patch. I'm getting massive failures when running the layout tests on ToT without this patch.
Comment 5 W. James MacLean 2012-02-10 14:09:21 PST
Created attachment 126580 [details]
Patch
Comment 6 W. James MacLean 2012-02-10 14:10:37 PST
I was over-zealous and removed something that lead to the test breakage. This patch should fix that.
Comment 7 James Robinson 2012-02-10 15:42:11 PST
I like this idea a lot.  It looks like you've hit conflicts with some of Anders' cleanups in ScrollableArea, mind resolving that and re-uploading?
Comment 8 Anders Carlsson 2012-02-10 17:07:55 PST
This is great! I was just wondering the other day why the scrollable area needed to know about zoom transforms :) Glad that it's obsolete.
Comment 9 W. James MacLean 2012-02-10 18:18:41 PST
(In reply to comment #7)
> I like this idea a lot.  It looks like you've hit conflicts with some of Anders' cleanups in ScrollableArea, mind resolving that and re-uploading?

NP, will do so tomorrow at some point.
Comment 10 W. James MacLean 2012-02-13 05:46:50 PST
Created attachment 126760 [details]
Patch
Comment 11 James Robinson 2012-02-13 10:16:57 PST
Comment on attachment 126760 [details]
Patch

R=me.  Please fix the mac build failure before landing:

/var/folders/db/z_22lpwn061cd362c11ktng40000gn/C/com.apple.Xcode.501/SharedPrecompiledHeaders/WebKit2Prefix-dklphnaxgqneptaesbgjjhyuylhp/WebKit2Prefix.h -c /Volumes/Data/WebKit/Source/WebKit2/WebProcess/Plugins/PDF/BuiltInPDFView.cpp -o /Volumes/Data/WebKit/WebKitBuild/WebKit2.build/Release/WebKit2.build/Objects-normal/x86_64/BuiltInPDFView.o
In file included from /Volumes/Data/WebKit/Source/WebKit2/WebProcess/Plugins/PDF/BuiltInPDFView.cpp:27:
/Volumes/Data/WebKit/Source/WebKit2/WebProcess/Plugins/PDF/BuiltInPDFView.h:143: error: 'ZoomAnimationState' has not been declared

I think all you need to do is delete the override
Comment 12 W. James MacLean 2012-02-13 10:36:21 PST
Created attachment 126793 [details]
Patch for landing
Comment 13 WebKit Review Bot 2012-02-13 20:42:12 PST
Comment on attachment 126793 [details]
Patch for landing

Clearing flags on attachment: 126793

Committed r107665: <http://trac.webkit.org/changeset/107665>
Comment 14 WebKit Review Bot 2012-02-13 20:42:18 PST
All reviewed patches have been landed.  Closing bug.