Bug 78354 - Rename [JSCustomPrototypeDefineOwnProperty] to [JSCustomDefineOwnPropertyOnPrototype]
Summary: Rename [JSCustomPrototypeDefineOwnProperty] to [JSCustomDefineOwnPropertyOnPr...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks: 77393
  Show dependency treegraph
 
Reported: 2012-02-10 05:25 PST by Kentaro Hara
Modified: 2012-02-12 02:54 PST (History)
5 users (show)

See Also:


Attachments
Patch (2.75 KB, patch)
2012-02-10 05:27 PST, Kentaro Hara
no flags Details | Formatted Diff | Diff
rebased patch for commit (2.68 KB, patch)
2012-02-12 01:06 PST, Kentaro Hara
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2012-02-10 05:25:38 PST
We can rename [JSCustomPrototypeDefineOwnProperty] to [JSCustomDefineOwnPropertyOnPrototype], for naming consistency with [JSCustomDefineOwnProperty] and [JSCustomNamedGetterOnPrototype].
Comment 1 Kentaro Hara 2012-02-10 05:27:51 PST
Created attachment 126505 [details]
Patch
Comment 2 WebKit Review Bot 2012-02-10 13:49:15 PST
Comment on attachment 126505 [details]
Patch

Rejecting attachment 126505 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
git/webkit-commit-queue/Source/WebKit/chromium/ui --revision 121421 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
45>At revision 121421.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/11480805
Comment 3 Kentaro Hara 2012-02-12 01:06:49 PST
Created attachment 126672 [details]
rebased patch for commit
Comment 4 WebKit Review Bot 2012-02-12 02:41:45 PST
Comment on attachment 126672 [details]
rebased patch for commit

Clearing flags on attachment: 126672

Committed r107506: <http://trac.webkit.org/changeset/107506>