WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 78353
Rename [JSCustomPrototypePutDelegate] to [JSCustomNamedGetterOnPrototype]
https://bugs.webkit.org/show_bug.cgi?id=78353
Summary
Rename [JSCustomPrototypePutDelegate] to [JSCustomNamedGetterOnPrototype]
Kentaro Hara
Reported
2012-02-10 05:15:53 PST
[JSCustomPrototypePutDelegate] is used to write custom code for named getters on a prototype interface. "PutDelegate" is just a method name in implementation and not so descriptive. We can rename it to [JSCustomNamedGetterOnPrototype]. This is also for naming consistency with [CustomNamedGetter].
Attachments
Patch
(3.29 KB, patch)
2012-02-10 05:18 PST
,
Kentaro Hara
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Kentaro Hara
Comment 1
2012-02-10 05:18:50 PST
Created
attachment 126504
[details]
Patch
WebKit Review Bot
Comment 2
2012-02-10 13:43:39 PST
Comment on
attachment 126504
[details]
Patch Clearing flags on attachment: 126504 Committed
r107436
: <
http://trac.webkit.org/changeset/107436
>
WebKit Review Bot
Comment 3
2012-02-10 13:43:45 PST
All reviewed patches have been landed. Closing bug.
Tony Chang
Comment 4
2012-02-10 14:27:05 PST
This appears to have regressed fast/forms/formmethod-attribute-input-html.html, fast/forms/formmethod-attribute-button-html.html and fast/forms/formaction-attribute.html which have to do with the formmethod attribute.
Tony Chang
Comment 5
2012-02-10 14:35:58 PST
(In reply to
comment #4
)
> This appears to have regressed fast/forms/formmethod-attribute-input-html.html, fast/forms/formmethod-attribute-button-html.html and fast/forms/formaction-attribute.html which have to do with the formmethod attribute.
Hmm, and now it's passing. I'll keep watching the bots to see if a pattern emerges.
Adam Barth
Comment 6
2012-02-10 14:40:56 PST
This change should only have affected JSC.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug