Bug 78353 - Rename [JSCustomPrototypePutDelegate] to [JSCustomNamedGetterOnPrototype]
Summary: Rename [JSCustomPrototypePutDelegate] to [JSCustomNamedGetterOnPrototype]
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks: 77393
  Show dependency tree / graph
 
Reported: 2012-02-10 05:15 PST by Kentaro Hara
Modified: 2012-02-10 14:40 PST (History)
6 users (show)

See Also:

Attachments
Patch (3.29 KB, patch)
2012-02-10 05:18 PST, Kentaro Hara 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2012-02-10 05:15:53 PST 
[JSCustomPrototypePutDelegate] is used to write custom code for named getters on a prototype interface. "PutDelegate" is just a method name in implementation and not so descriptive. We can rename it to [JSCustomNamedGetterOnPrototype]. This is also for naming consistency with [CustomNamedGetter].
Comment 1 Kentaro Hara 2012-02-10 05:18:50 PST 
Created attachment 126504 [details]
Patch
Comment 2 WebKit Review Bot 2012-02-10 13:43:39 PST 
Comment on attachment 126504 [details]
Patch

Clearing flags on attachment: 126504

Committed r107436: <http://trac.webkit.org/changeset/107436>
Comment 3 WebKit Review Bot 2012-02-10 13:43:45 PST 
All reviewed patches have been landed.  Closing bug.
Comment 4 Tony Chang 2012-02-10 14:27:05 PST 
This appears to have regressed fast/forms/formmethod-attribute-input-html.html, fast/forms/formmethod-attribute-button-html.html and fast/forms/formaction-attribute.html which have to do with the formmethod attribute.
Comment 5 Tony Chang 2012-02-10 14:35:58 PST 
(In reply to comment #4)
> This appears to have regressed fast/forms/formmethod-attribute-input-html.html, fast/forms/formmethod-attribute-button-html.html and fast/forms/formaction-attribute.html which have to do with the formmethod attribute.

Hmm, and now it's passing.  I'll keep watching the bots to see if a pattern emerges.
Comment 6 Adam Barth 2012-02-10 14:40:56 PST 
This change should only have affected JSC.