Bug 78349 - Web Inspector: Make ScriptsNavigator default file selector.
Summary: Web Inspector: Make ScriptsNavigator default file selector.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Vsevolod Vlasov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-10 04:18 PST by Vsevolod Vlasov
Modified: 2012-02-14 04:56 PST (History)
11 users (show)

See Also:

Attachments
Patch (48.24 KB, patch)
2012-02-10 08:12 PST, Vsevolod Vlasov 		pfeldman: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vsevolod Vlasov 2012-02-10 04:18:54 PST 
Make ScriptsNavigator default file selector.

This includes:
 - Move ScriptsNavigator out of experiments
 - Introduce new setting "useScriptsNavigator" with true as default value
 - Update tests:
    - For each old file selector test create relevant ScriptsNavigator test and make sure these tests pass.
    - Disable some old file selector tests (this features should be now covered by ScriptsNavigator tests)
Comment 1 Vsevolod Vlasov 2012-02-10 08:12:50 PST 
Created attachment 126517 [details]
Patch
Comment 2 Vsevolod Vlasov 2012-02-13 09:50:35 PST 
Committed r107582: <http://trac.webkit.org/changeset/107582>
Comment 3 Tony Chang 2012-02-13 14:52:42 PST 
It looks like this caused 3 interactive_ui_tests to fail.  I'm going to roll out the patch.
Comment 5 Tony Chang 2012-02-13 14:56:01 PST 
Reverted r107582 for reason:

Broke three inspector interactive_ui_tests

Committed r107615: <http://trac.webkit.org/changeset/107615>
Comment 6 Tony Chang 2012-02-13 14:56:30 PST 
(In reply to comment #3)
> It looks like this caused 3 interactive_ui_tests to fail.  I'm going to roll out the patch.

If this is expected behavior, please disable the tests in Chromium before relanding this patch.
Comment 7 Vsevolod Vlasov 2012-02-14 04:56:15 PST 
Committed r107708: <http://trac.webkit.org/changeset/107708>