WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
78349
Web Inspector: Make ScriptsNavigator default file selector.
https://bugs.webkit.org/show_bug.cgi?id=78349
Summary
Web Inspector: Make ScriptsNavigator default file selector.
Vsevolod Vlasov
Reported
2012-02-10 04:18:54 PST
Make ScriptsNavigator default file selector. This includes: - Move ScriptsNavigator out of experiments - Introduce new setting "useScriptsNavigator" with true as default value - Update tests: - For each old file selector test create relevant ScriptsNavigator test and make sure these tests pass. - Disable some old file selector tests (this features should be now covered by ScriptsNavigator tests)
Attachments
Patch
(48.24 KB, patch)
2012-02-10 08:12 PST
,
Vsevolod Vlasov
pfeldman
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Vsevolod Vlasov
Comment 1
2012-02-10 08:12:50 PST
Created
attachment 126517
[details]
Patch
Vsevolod Vlasov
Comment 2
2012-02-13 09:50:35 PST
Committed
r107582
: <
http://trac.webkit.org/changeset/107582
>
Tony Chang
Comment 3
2012-02-13 14:52:42 PST
It looks like this caused 3 interactive_ui_tests to fail. I'm going to roll out the patch.
Tony Chang
Comment 4
2012-02-13 14:53:11 PST
http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests/builds/18541
Tony Chang
Comment 5
2012-02-13 14:56:01 PST
Reverted
r107582
for reason: Broke three inspector interactive_ui_tests Committed
r107615
: <
http://trac.webkit.org/changeset/107615
>
Tony Chang
Comment 6
2012-02-13 14:56:30 PST
(In reply to
comment #3
)
> It looks like this caused 3 interactive_ui_tests to fail. I'm going to roll out the patch.
If this is expected behavior, please disable the tests in Chromium before relanding this patch.
Vsevolod Vlasov
Comment 7
2012-02-14 04:56:15 PST
Committed
r107708
: <
http://trac.webkit.org/changeset/107708
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug