RESOLVED FIXED Bug 78342
Remove [CPPCustom] from CodeGeneratorCPP.pm 
https://bugs.webkit.org/show_bug.cgi?id=78342
Summary Remove [CPPCustom] from CodeGeneratorCPP.pm
Kentaro Hara
Reported 2012-02-10 02:56:52 PST
[CPPCustom] is used in DOMWindow.location only. [CPPCustom] means that the attribute or method should be ignored because CPP does not support it. - At least, it should be renamed to [CPPIgnore] (or something like that). - There are many attributes and methods that CPP does not support (e.g. [CallWith=...], [CustomSetter], etc), but they are not yet marked with [CPPCustom] (except for DOMWindow.location). CPP just generates "meaningless" code for those unsupported attributes and methods. - Ideally we can mark all unsupported attributes and functions with [CPPCustom], but it would not be so practical. Otherwise, removing [CPPCustom] would make sense. The side effect of removing [CPPCustom] is just that CPP will generate "meaningless" code for DOMWindow.location.
Attachments
Patch (3.10 KB, patch)
2012-02-10 03:06 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
rebased patch for commit (3.03 KB, patch)
2012-02-12 01:15 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2012-02-10 03:06:33 PST
Created attachment 126487 [details] Patch
Adam Barth
Comment 2 2012-02-10 09:23:56 PST
Comment on attachment 126487 [details] Patch ok
WebKit Review Bot
Comment 3 2012-02-10 15:03:25 PST
Comment on attachment 126487 [details] Patch Rejecting attachment 126487 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: om patch file(s). patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/bindings/scripts/CodeGeneratorCPP.pm Hunk #1 FAILED at 194. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/bindings/scripts/CodeGeneratorCPP.pm.rej patching file Source/WebCore/page/DOMWindow.idl Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Adam Barth']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/11473818
Kentaro Hara
Comment 4 2012-02-12 01:15:12 PST
Created attachment 126673 [details] rebased patch for commit
WebKit Review Bot
Comment 5 2012-02-12 03:16:43 PST
Comment on attachment 126673 [details] rebased patch for commit Clearing flags on attachment: 126673 Committed r107508: <http://trac.webkit.org/changeset/107508>
Note You need to log in before you can comment on or make changes to this bug.