Bug 78335 - Remove [ConvertScriptString] from FileReaderSync.idl
Summary: Remove [ConvertScriptString] from FileReaderSync.idl
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
Depends on:
Blocks: 77393
  Show dependency treegraph
Reported: 2012-02-10 01:12 PST by Kentaro Hara
Modified: 2012-02-16 16:10 PST (History)
8 users (show)

See Also:

Patch (28.57 KB, patch)
2012-02-12 18:16 PST, Kentaro Hara
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2012-02-10 01:12:06 PST
[ConvertScriptString] is used by FileReaderSync.idl only. The difference between [ConvertScriptString] and [TreatReturnedNullStringAs=Null] is whether the returned string is generated by jsString() or jsOwnedString() in JSC (No difference in V8).

I am not sure why (only) FileReaderSync.idl requires jsOwnedString(). If it is not necessary, I would like to replace [ConvertScriptString] with [TreatReturnedNullStringAs=Null], and remove [ConvertScriptString] completely from code generators.

Any advice?
Comment 1 Kentaro Hara 2012-02-12 18:00:56 PST
The spec says that FileReadSync should throw NOT_FOUND_ERR if a given blob is invalid: http://www.w3.org/TR/FileAPI/#FileReaderSync

By throwing NOT_FOUND_ERR if a given blob is invalid, we can remove [ConvertScriptString] from FileReadSync.idl.
Comment 2 Kentaro Hara 2012-02-12 18:16:50 PST
Created attachment 126699 [details]
Comment 3 Eric Seidel (no email) 2012-02-16 13:15:35 PST
Comment on attachment 126699 [details]

Comment 4 WebKit Review Bot 2012-02-16 16:10:40 PST
Comment on attachment 126699 [details]

Clearing flags on attachment: 126699

Committed r107994: <http://trac.webkit.org/changeset/107994>
Comment 5 WebKit Review Bot 2012-02-16 16:10:45 PST
All reviewed patches have been landed.  Closing bug.