RESOLVED FIXED 78335
Remove [ConvertScriptString] from FileReaderSync.idl 
https://bugs.webkit.org/show_bug.cgi?id=78335
Summary Remove [ConvertScriptString] from FileReaderSync.idl
Kentaro Hara
Reported 2012-02-10 01:12:06 PST
[ConvertScriptString] is used by FileReaderSync.idl only. The difference between [ConvertScriptString] and [TreatReturnedNullStringAs=Null] is whether the returned string is generated by jsString() or jsOwnedString() in JSC (No difference in V8). I am not sure why (only) FileReaderSync.idl requires jsOwnedString(). If it is not necessary, I would like to replace [ConvertScriptString] with [TreatReturnedNullStringAs=Null], and remove [ConvertScriptString] completely from code generators. Any advice?
Attachments
Patch (28.57 KB, patch)
2012-02-12 18:16 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2012-02-12 18:00:56 PST
The spec says that FileReadSync should throw NOT_FOUND_ERR if a given blob is invalid: http://www.w3.org/TR/FileAPI/#FileReaderSync By throwing NOT_FOUND_ERR if a given blob is invalid, we can remove [ConvertScriptString] from FileReadSync.idl.
Kentaro Hara
Comment 2 2012-02-12 18:16:50 PST
Created attachment 126699 [details] Patch
Eric Seidel (no email)
Comment 3 2012-02-16 13:15:35 PST
Comment on attachment 126699 [details] Patch LGTM.
WebKit Review Bot
Comment 4 2012-02-16 16:10:40 PST
Comment on attachment 126699 [details] Patch Clearing flags on attachment: 126699 Committed r107994: <http://trac.webkit.org/changeset/107994>
WebKit Review Bot
Comment 5 2012-02-16 16:10:45 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.