Bug 78333 - Rename classes defined in ContentInclusionSelector to more suitable names which match the spec
Summary: Rename classes defined in ContentInclusionSelector to more suitable names whi...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hayato Ito
URL:
Keywords:
Depends on:
Blocks: 63606
  Show dependency tree / graph
 
Reported: 2012-02-10 01:11 PST by Hayato Ito
Modified: 2012-02-13 04:15 PST (History)
7 users (show)

See Also:

Attachments
rename (48.44 KB, patch)
2012-02-10 03:22 PST, Hayato Ito 		no flags Details | Formatted Diff | Diff
update. (53.72 KB, patch)
2012-02-10 03:46 PST, Hayato Ito 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hayato Ito 2012-02-10 01:11:12 PST 
The current class names defined in ContentInclusionSelector are not intuitive.
It would be nice that we have more intuitive names which use the terms defined in the spec.
Comment 1 Hayato Ito 2012-02-10 01:20:00 PST 
How about this?

ContentInclusionSelector -> HostChildNodesSelector
ShadowInclusionSet       -> HostChildNodesSelectionSet
ShadowInclusionList      -> HostChildNodesSelectionList
ShadowInclusion          -> HostChildNodesSelection

If there is no objection, let me rename.
Comment 2 Hajime Morrita 2012-02-10 02:09:04 PST 
"Nodes" looks redundant, especially inside a noun? I guess it's ok to rename it HTMLContent something, considering it's for <content>. and they are under html/shadow.
Comment 3 Hayato Ito 2012-02-10 02:35:39 PST 
Okay.

Let me rename as follows:
ContentInclusionSelector -> HTMLContentSelector
ShadowInclusionSet       -> HTMLContentSelectionSet
ShadowInclusionList      -> HTMLContentSelectionList
ShadowInclusion          -> HTMLContentSelection

I also rename member functions and variables to match the names.

(In reply to comment #2)
> "Nodes" looks redundant, especially inside a noun? I guess it's ok to rename it HTMLContent something, considering it's for <content>. and they are under html/shadow.
Comment 4 Hayato Ito 2012-02-10 03:22:57 PST 
Created attachment 126488 [details]
rename
Comment 5 Hayato Ito 2012-02-10 03:46:38 PST 
Created attachment 126493 [details]
update.
Comment 6 Hayato Ito 2012-02-10 03:49:37 PST 
Most renaming is done. The patch is reedy for review.
Follow-up patch will do remaining renaming, such as renaming window.Internals binding.
Comment 7 Hayato Ito 2012-02-12 17:50:51 PST 
Morrita-san, could you take a look?
Comment 8 WebKit Review Bot 2012-02-13 04:15:42 PST 
Comment on attachment 126493 [details]
update.

Clearing flags on attachment: 126493

Committed r107558: <http://trac.webkit.org/changeset/107558>
Comment 9 WebKit Review Bot 2012-02-13 04:15:48 PST 
All reviewed patches have been landed.  Closing bug.