Bug 78327 - Replace [CustomArgumentHandling] with [CallWith=ScriptArguments|CallStack]
Summary: Replace [CustomArgumentHandling] with [CallWith=ScriptArguments|CallStack]
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks: 77393
  Show dependency treegraph
 
Reported: 2012-02-09 22:23 PST by Kentaro Hara
Modified: 2012-02-10 04:38 PST (History)
8 users (show)

See Also:


Attachments
Patch (54.19 KB, patch)
2012-02-09 23:12 PST, Kentaro Hara
no flags Details | Formatted Diff | Diff
fixed patch to see if gtk build passes (51.14 KB, patch)
2012-02-10 02:08 PST, Kentaro Hara
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2012-02-09 22:23:31 PST
We can replace [CustomArgumentHandling] with [CallWith=ScriptArguments|CallStack]. At present, [CustomArgumentHandling] is used by Console.idl only.
Comment 1 Kentaro Hara 2012-02-09 23:12:46 PST
Created attachment 126461 [details]
Patch
Comment 2 WebKit Review Bot 2012-02-09 23:14:43 PST
Attachment 126461 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:1332:  Local variables should never be PassRefPtr (see http://webkit.org/coding/RefPtr.html).  [readability/pass_ptr] [5]
Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:1345:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 2 in 19 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Adam Barth 2012-02-09 23:17:42 PST
Comment on attachment 126461 [details]
Patch

Nice.
Comment 4 Kentaro Hara 2012-02-09 23:20:07 PST
Comment on attachment 126461 [details]
Patch

Let me land manually to avoid style check errors in generated code.
Comment 5 Philippe Normand 2012-02-09 23:27:09 PST
Comment on attachment 126461 [details]
Patch

Attachment 126461 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/11487624
Comment 6 Kentaro Hara 2012-02-09 23:38:40 PST
Committed r107368: <http://trac.webkit.org/changeset/107368>
Comment 7 Kentaro Hara 2012-02-09 23:57:36 PST
Reverted r107368 for reason:

break GTK build

Committed r107371: <http://trac.webkit.org/changeset/107371>
Comment 8 Kentaro Hara 2012-02-10 02:08:55 PST
Created attachment 126481 [details]
fixed patch to see if gtk build passes
Comment 9 WebKit Review Bot 2012-02-10 04:38:46 PST
Comment on attachment 126481 [details]
fixed patch to see if gtk build passes

Clearing flags on attachment: 126481

Committed r107396: <http://trac.webkit.org/changeset/107396>
Comment 10 WebKit Review Bot 2012-02-10 04:38:51 PST
All reviewed patches have been landed.  Closing bug.