Bug 78325 - CSS3 calc: update font-size test to use pre/post js
Summary: CSS3 calc: update font-size test to use pre/post js
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mike Lawther
URL:
Keywords:
Depends on:
Blocks: 16662
  Show dependency tree / graph
 
Reported: 2012-02-09 21:30 PST by Mike Lawther
Modified: 2012-02-10 12:08 PST (History)
1 user (show)

See Also:

Attachments
Patch (3.85 KB, patch)
2012-02-09 21:31 PST, Mike Lawther 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Lawther 2012-02-09 21:30:48 PST 
CSS3 calc: update font-size test to use pre/post js
Comment 1 Mike Lawther 2012-02-09 21:31:27 PST 
Created attachment 126448 [details]
Patch
Comment 2 Ojan Vafai 2012-02-10 10:30:34 PST 
Comment on attachment 126448 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=126448&action=review

> LayoutTests/css3/calc/font-size.html:22
> +    shouldBeEqualToString('getComputedStyle(document.getElementById("' + spans[i].id + '"), null).fontSize', getComputedStyle(document.getElementById("control"), null).fontSize);

In future tests, you could make this more readable by creating a helper function: 
function fontSize(id) {
    return getComputedStyle(document.getElementById("' + id + '"), null).fontSize;
}
Comment 3 WebKit Review Bot 2012-02-10 12:08:13 PST 
Comment on attachment 126448 [details]
Patch

Clearing flags on attachment: 126448

Committed r107425: <http://trac.webkit.org/changeset/107425>
Comment 4 WebKit Review Bot 2012-02-10 12:08:17 PST 
All reviewed patches have been landed.  Closing bug.