Bug 78324 – Get rid of the LocalizationStrategy

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Benjamin Poulain]

Today, all the localized string come from LocalizationStrategy.

From there we get an instance of LocalizationStrategy, and call the right virtual method.

Adding a string require at least 6 files just to add the translation.

The only platform needing LocalizationStrategy is Qt. I have the feeling we could greatly simplify this by just having a different cpp file for the handful of string Qt needs.

[Benjamin Poulain]

Created attachment 126606 [details]
Patch

[Benjamin Poulain]

This is a first attempt for the bots. This is a massive amount of cleaning :)

[Benjamin Poulain]

Created attachment 126610 [details]
Patch

[WebKit Review Bot]

Comment on attachment 126610 [details]
Patch

Attachment 126610 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11496601

[Sam Weinig]

Great! I have been meaning to get around to doing this.

[Benjamin Poulain]

Created attachment 126646 [details]
Patch

[Gyuyoung Kim]

Comment on attachment 126646 [details]
Patch

Attachment 126646 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/11506232

[Early Warning System Bot]

Comment on attachment 126646 [details]
Patch

Attachment 126646 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/11508229

[Benjamin Poulain]

Created attachment 126656 [details]
Patch

[Early Warning System Bot]

Comment on attachment 126656 [details]
Patch

Attachment 126656 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/11505304

[Benjamin Poulain]

Created attachment 126657 [details]
Patch

[Early Warning System Bot]

Comment on attachment 126657 [details]
Patch

Attachment 126657 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/11506272

[Benjamin Poulain]

Created attachment 126660 [details]
Patch

[Benjamin Poulain]

Finalllly, something that build on Qt :)

[Benjamin Poulain]

Created attachment 126665 [details]
Patch

[Philippe Normand]

Comment on attachment 126665 [details]
Patch

Attachment 126665 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/11511082

[Benjamin Poulain]

Created attachment 127020 [details]
Patch

[Benjamin Poulain]

Created attachment 127047 [details]
Patch

[Antonio Gomes]

does this help? http://queues.webkit.org/submit-to-ews  :)

[Benjamin Poulain]

(In reply to comment #19)
> does this help? http://queues.webkit.org/submit-to-ews  :)

I just attach the patch and click on "submit to ews". It looks like I nailed them all except win. Hopefully this last attempt fix the last problem on Windows. :)

[Sam Weinig]

Comment on attachment 127047 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=127047&action=review

Nice.

> Source/WebCore/ChangeLog:266
> +        (WebCore::localizedMediaControlElementHelpText):
> +        (WebCore::localizedMediaTimeDescription):
> +        (WebCore::validationMessageValueMissingText):
> +        (WebCore::validationMessageValueMissingForCheckboxText):
> +        (WebCore::validationMessageValueMissingForFileText):
> +        (WebCore::validationMessageValueMissingForMultipleFileText):
> +        (WebCore::validationMessageValueMissingForRadioText):
> +        (WebCore::validationMessageValueMissingForSelectText):
> +        (WebCore::validationMessageTypeMismatchText):
> +        (WebCore::validationMessageTypeMismatchForEmailText):
> +        (WebCore::validationMessageTypeMismatchForMultipleEmailText):
> +        (WebCore::validationMessageTypeMismatchForURLText):
> +        (WebCore::validationMessagePatternMismatchText):
> +        (WebCore::validationMessageTooLongText):
> +        (WebCore::validationMessageRangeUnderflowText):
> +        (WebCore::validationMessageRangeOverflowText):
> +        (WebCore::validationMessageStepMismatchText):

I don't think all these are needed in the change log.

[Benjamin Poulain]

Created attachment 127909 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 127909 [details]
Patch for landing

Clearing flags on attachment: 127909

Committed r108308: <http://trac.webkit.org/changeset/108308>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Csaba Osztrogonác]

Reopen, because it broke the Qt build:
g++ -m64 -fuse-ld=gold -Wl,--gc-sections -Wl,--no-undefined -Wl,-O1 -Wl,-rpath,/usr/local/Trolltech/Qt5/Qt-5.0.0-r22/lib -shared -Wl,-Bsymbolic-functions -Wl,-soname,libQtWebKit.so.4 -o libQtWebKit.so.4.10.0 obj/release/WebKit/qt/Api/qwebframe.o obj/release/WebKit/qt/Api/qgraphicswebview.o obj/release/WebKit/qt/Api/qwebpage.o obj/release/WebKit/qt/Api/qwebview.o obj/release/WebKit/qt/Api/qwebelement.o obj/release/WebKit/qt/Api/qwebhistory.o obj/release/WebKit/qt/Api/qwebsettings.o obj/release/WebKit/qt/Api/qwebhistoryinterface.o obj/release/WebKit/qt/Api/qwebplugindatabase.o obj/release/WebKit/qt/Api/qwebpluginfactory.o obj/release/WebKit/qt/Api/qwebsecurityorigin.o obj/release/WebKit/qt/Api/qwebscriptworld.o obj/release/WebKit/qt/Api/qwebdatabase.o obj/release/WebKit/qt/Api/qwebinspector.o obj/release/WebKit/qt/Api/qwebkitversion.o obj/release/WebKit/qt/Api/qhttpheader.o obj/release/WebKit/qt/WebCoreSupport/QtFallbackWebPopup.o obj/release/WebKit/qt/WebCoreSupport/QtWebComboBox.o obj/release/WebKit/qt/WebCoreSupport/ChromeClientQt.o obj/release/WebKit/qt/WebCoreSupport/ContextMenuClientQt.o obj/release/WebKit/qt/WebCoreSupport/DragClientQt.o obj/release/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.o obj/release/WebKit/qt/WebCoreSupport/EditorClientQt.o obj/release/WebKit/qt/WebCoreSupport/UndoStepQt.o obj/release/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.o obj/release/WebKit/qt/WebCoreSupport/FrameNetworkingContextQt.o obj/release/WebKit/qt/WebCoreSupport/GeolocationPermissionClientQt.o obj/release/WebKit/qt/WebCoreSupport/InitWebCoreQt.o obj/release/WebKit/qt/WebCoreSupport/InspectorClientQt.o obj/release/WebKit/qt/WebCoreSupport/InspectorServerQt.o obj/release/WebKit/qt/WebCoreSupport/NotificationPresenterClientQt.o obj/release/WebKit/qt/WebCoreSupport/PageClientQt.o obj/release/WebKit/qt/WebCoreSupport/PopupMenuQt.o obj/release/WebKit/qt/WebCoreSupport/QtPlatformPlugin.o obj/release/WebKit/qt/WebCoreSupport/SearchPopupMenuQt.o obj/release/WebKit/qt/WebCoreSupport/TextCheckerClientQt.o obj/release/WebKit/qt/WebCoreSupport/PlatformStrategiesQt.o obj/release/WebKit/qt/WebCoreSupport/WebEventConversion.o obj/release/WebKit/qt/WebCoreSupport/FullScreenVideoQt.o obj/release/WebKit/qt/WebCoreSupport/IconDatabaseClientQt.o obj/release/WebKit/qt/WebCoreSupport/GeolocationClientQt.o obj/release/home/webkitbuildbot/slaves/release64bit-perf/buildslave/qt-linux-64-release-perf-tests/build/WebKitBuild/Release/Source/moc/moc_qwebkitplatformplugin.o obj/release/home/webkitbuildbot/slaves/release64bit-perf/buildslave/qt-linux-64-release-perf-tests/build/WebKitBuild/Release/Source/moc/moc_qwebhistoryinterface.o obj/release/home/webkitbuildbot/slaves/release64bit-perf/buildslave/qt-linux-64-release-perf-tests/build/WebKitBuild/Release/Source/moc/moc_qwebpluginfactory.o obj/release/home/webkitbuildbot/slaves/release64bit-perf/buildslave/qt-linux-64-release-perf-tests/build/WebKitBuild/Release/Source/moc/moc_qwebinspector.o obj/release/home/webkitbuildbot/slaves/release64bit-perf/buildslave/qt-linux-64-release-perf-tests/build/WebKitBuild/Release/Source/moc/moc_qwebplugindatabase_p.o obj/release/home/webkitbuildbot/slaves/release64bit-perf/buildslave/qt-linux-64-release-perf-tests/build/WebKitBuild/Release/Source/moc/moc_InspectorServerQt.o obj/release/home/webkitbuildbot/slaves/release64bit-perf/buildslave/qt-linux-64-release-perf-tests/build/WebKitBuild/Release/Source/moc/moc_QtFallbackWebPopup.o obj/release/home/webkitbuildbot/slaves/release64bit-perf/buildslave/qt-linux-64-release-perf-tests/build/WebKitBuild/Release/Source/moc/moc_QtWebComboBox.o obj/release/home/webkitbuildbot/slaves/release64bit-perf/buildslave/qt-linux-64-release-perf-tests/build/WebKitBuild/Release/Source/moc/moc_FullScreenVideoQt.o   -L/home/webkitbuildbot/slaves/release64bit-perf/buildslave/qt-linux-64-release-perf-tests/build/WebKitBuild/Release/Source/WebKit2/release -L/home/webkitbuildbot/slaves/release64bit-perf/buildslave/qt-linux-64-release-perf-tests/build/WebKitBuild/Release/Source/WebCore/release -L/home/webkitbuildbot/slaves/release64bit-perf/buildslave/qt-linux-64-release-perf-tests/build/WebKitBuild/Release/Source/JavaScriptCore/release -L/home/webkitbuildbot/slaves/release64bit-perf/buildslave/qt-linux-64-release-perf-tests/build/WebKitBuild/Release/Source/WTF/release -L/usr/local/Trolltech/Qt5/Qt-5.0.0-r22/lib -L/usr/X11R6/lib64 -Wl,-whole-archive -lWebKit2 -Wl,-no-whole-archive -Wl,-whole-archive -lWebCore -Wl,-no-whole-archive -lsqlite3 -Wl,-whole-archive -lJavaScriptCore -Wl,-no-whole-archive -Wl,-whole-archive -lWTF -Wl,-no-whole-archive -licui18n -licuuc -licudata -lgio-2.0 -lgstapp-0.10 -lgstinterfaces-0.10 -lgstpbutils-0.10 -pthread -lgstvideo-0.10 -lgstbase-0.10 -lgstreamer-0.10 -lgobject-2.0 -lgmodule-2.0 -lxml2 -lgthread-2.0 -lrt -lglib-2.0 -lQtQuick -L/usr/local/Trolltech/Qt5/Qt-5.0.0-r22/lib -L/home/wkperf/sources/qt5/qtdeclarative/lib -L/usr/X11R6/lib64 -lQtDeclarative -lQtV8 -lQtLocation -lQt3D -lQtOpenGL -lQtPrintSupport -lQtXmlPatterns -lQtWidgets -lQtSql -lQtSensors -lQtNetwork -lQtGui -lQtCore -lGL -lpthread  
/home/webkitbuildbot/slaves/release64bit-perf/buildslave/qt-linux-64-release-perf-tests/build/WebKitBuild/Release/Source/WebKit2/release/libWebKit2.a(WebPlatformStrategies.o):(.data.rel.ro._ZTVN6WebKit21WebPlatformStrategiesE[vtable for WebKit::WebPlatformStrategies]+0x30): undefined reference to `WebCore::PlatformStrategies::createLocalizationStrategy()'
c

[Benjamin Poulain]

Given all Qt bots are building now, I assume it was a problem with the Qt bots.