RESOLVED FIXED Bug 78309
Perf-o-matic should process reports in background 
https://bugs.webkit.org/show_bug.cgi?id=78309
Summary Perf-o-matic should process reports in background
Ryosuke Niwa
Reported 2012-02-09 18:13:33 PST
I just realized that there are a whole bunch of ReportLog objects sitting in the production server because appengine ran out of time to run report_handler.py :( When appengine cold-starts, it takes extra time to compile the scripts and end up not being able to finish the request. As someone worked on the flakiness dashboard suggested before, we should do the whole parsing, processing, etc... in background instead. We also need some UI to salvage the lost reports.
Attachments
Patch (40.23 KB, patch)
2012-02-10 01:02 PST, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Removed report_logs_handler.pyc (37.02 KB, patch)
2012-02-10 01:05 PST, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Fixed yaml > html (38.81 KB, patch)
2012-02-10 01:45 PST, Ryosuke Niwa 		morrita: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2012-02-10 01:02:17 PST
Created attachment 126471 [details] Patch
Ryosuke Niwa
Comment 2 2012-02-10 01:05:16 PST
Created attachment 126472 [details] Removed report_logs_handler.pyc
Hajime Morrita
Comment 3 2012-02-10 01:14:57 PST
Comment on attachment 126472 [details] Removed report_logs_handler.pyc View in context: https://bugs.webkit.org/attachment.cgi?id=126472&action=review I really want to see the unittest. for this. You can test datastore even locally. http://code.google.com/appengine/docs/python/tools/localunittesting.html > Websites/webkit-perf.appspot.com/report_logs.yaml:1 > +<!DOCTYPE html> This doesn't look like a yaml at all.
Ryosuke Niwa
Comment 4 2012-02-10 01:22:13 PST
(In reply to comment #3) > (From update of attachment 126472 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=126472&action=review > > I really want to see the unittest. for this. > You can test datastore even locally. > http://code.google.com/appengine/docs/python/tools/localunittesting.html I don't think testing model code is interesting since most of the logic lives in handler classes at the moment. > > Websites/webkit-perf.appspot.com/report_logs.yaml:1 > > +<!DOCTYPE html> > > This doesn't look like a yaml at all. What do you mean?
Ryosuke Niwa
Comment 5 2012-02-10 01:24:20 PST
FWIW, this code has been pushed into the production.
Ryosuke Niwa
Comment 6 2012-02-10 01:45:12 PST
Created attachment 126476 [details] Fixed yaml > html
Ryosuke Niwa
Comment 7 2012-02-10 01:56:14 PST
Committed r107386: <http://trac.webkit.org/changeset/107386>
Ryosuke Niwa
Comment 8 2012-02-10 03:26:39 PST
Build fix landed in http://trac.webkit.org/changeset/107393.
Note You need to log in before you can comment on or make changes to this bug.