Bug 78308 - The JS Parser scope object needs a VectorTrait specialization
Summary: The JS Parser scope object needs a VectorTrait specialization
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Oliver Hunt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-09 18:13 PST by Oliver Hunt
Modified: 2012-02-10 10:37 PST (History)
1 user (show)

See Also:


Attachments
Patch (5.95 KB, patch)
2012-02-09 18:16 PST, Oliver Hunt
barraclough: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Hunt 2012-02-09 18:13:31 PST
The JS Parser scope object needs a VectorTrait specialization
Comment 1 Oliver Hunt 2012-02-09 18:16:22 PST
Created attachment 126421 [details]
Patch
Comment 2 Gavin Barraclough 2012-02-09 18:20:13 PST
Comment on attachment 126421 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=126421&action=review

> Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:418
> +    if (1) {

Oooops, you probably want to remove that.

> Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:1227
> +            if (JSActivation* activation = jsDynamicCast<JSActivation*>(currentVariableObject))

Will this if be optimized out in release builds? – I'd prefer to see:
    ASSERT(!jsDynamicCast<JSActivation*>(currentVariableObject) || jsDynamicCast<JSActivation*>(currentVariableObject)->isValidScopedLookup(entry.getIndex()));
Comment 3 Oliver Hunt 2012-02-09 18:26:34 PST
Committed r107338: <http://trac.webkit.org/changeset/107338>
Comment 4 Geoffrey Garen 2012-02-10 10:37:04 PST
<rdar://problem/10734517>