RESOLVED FIXED 78304
Web Inspector: Prevent attaching when inspecting the Web Inspector 
https://bugs.webkit.org/show_bug.cgi?id=78304
Summary Web Inspector: Prevent attaching when inspecting the Web Inspector
Timothy Hatcher
Reported 2012-02-09 17:54:48 PST
We should prevent attaching when inspecting the Web Inspector. It is confusing and fails bad in WebKit2.
Attachments
Proposed Change (6.40 KB, patch)
2012-02-09 17:58 PST, Timothy Hatcher 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Timothy Hatcher
Comment 1 2012-02-09 17:58:56 PST
Created attachment 126414 [details] Proposed Change
Brian Weinstein
Comment 2 2012-02-09 18:52:29 PST
Comment on attachment 126414 [details] Proposed Change View in context: https://bugs.webkit.org/attachment.cgi?id=126414&action=review > Source/WebKit2/UIProcess/WebInspectorProxy.cpp:272 > + unsigned maximumAttachedHeight = inspectedPageHeight * 3 / 4; Is it worth it to use a constant for 3/4 like WebCore? It seems like we could just put it in WebInspectorProxy.h next to minimumAttachedHeight.
Timothy Hatcher
Comment 3 2012-02-09 18:54:25 PST
Comment on attachment 126414 [details] Proposed Change View in context: https://bugs.webkit.org/attachment.cgi?id=126414&action=review >> Source/WebKit2/UIProcess/WebInspectorProxy.cpp:272 >> + unsigned maximumAttachedHeight = inspectedPageHeight * 3 / 4; > > Is it worth it to use a constant for 3/4 like WebCore? It seems like we could just put it in WebInspectorProxy.h next to minimumAttachedHeight. IIRC, we can't use "static float" in class headers on Windows, so that is why we never did that.
WebKit Review Bot
Comment 4 2012-02-09 22:24:05 PST
Comment on attachment 126414 [details] Proposed Change Clearing flags on attachment: 126414 Committed r107362: <http://trac.webkit.org/changeset/107362>
WebKit Review Bot
Comment 5 2012-02-09 22:24:10 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.