Bug 78304 - Web Inspector: Prevent attaching when inspecting the Web Inspector
Summary: Web Inspector: Prevent attaching when inspecting the Web Inspector
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-09 17:54 PST by Timothy Hatcher
Modified: 2012-02-09 22:24 PST (History)
11 users (show)

See Also:

Attachments
Proposed Change (6.40 KB, patch)
2012-02-09 17:58 PST, Timothy Hatcher 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2012-02-09 17:54:48 PST 
We should prevent attaching when inspecting the Web Inspector. It is confusing and fails bad in WebKit2.
Comment 1 Timothy Hatcher 2012-02-09 17:58:56 PST 
Created attachment 126414 [details]
Proposed Change
Comment 2 Brian Weinstein 2012-02-09 18:52:29 PST 
Comment on attachment 126414 [details]
Proposed Change

View in context: https://bugs.webkit.org/attachment.cgi?id=126414&action=review

> Source/WebKit2/UIProcess/WebInspectorProxy.cpp:272
> +    unsigned maximumAttachedHeight = inspectedPageHeight * 3 / 4;

Is it worth it to use a constant for 3/4 like WebCore? It seems like we could just put it in WebInspectorProxy.h next to minimumAttachedHeight.
Comment 3 Timothy Hatcher 2012-02-09 18:54:25 PST 
Comment on attachment 126414 [details]
Proposed Change

View in context: https://bugs.webkit.org/attachment.cgi?id=126414&action=review

>> Source/WebKit2/UIProcess/WebInspectorProxy.cpp:272
>> +    unsigned maximumAttachedHeight = inspectedPageHeight * 3 / 4;
> 
> Is it worth it to use a constant for 3/4 like WebCore? It seems like we could just put it in WebInspectorProxy.h next to minimumAttachedHeight.

IIRC, we can't use "static float" in class headers on Windows, so that is why we never did that.
Comment 4 WebKit Review Bot 2012-02-09 22:24:05 PST 
Comment on attachment 126414 [details]
Proposed Change

Clearing flags on attachment: 126414

Committed r107362: <http://trac.webkit.org/changeset/107362>
Comment 5 WebKit Review Bot 2012-02-09 22:24:10 PST 
All reviewed patches have been landed.  Closing bug.