WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
78301
Rename compare_text and compare_audio to make it clear that they're !=
https://bugs.webkit.org/show_bug.cgi?id=78301
Summary
Rename compare_text and compare_audio to make it clear that they're !=
Eric Seidel (no email)
Reported
2012-02-09 17:54:14 PST
Rename compare_text and compare_audio to make it clear that they're !=
Attachments
Patch
(12.41 KB, patch)
2012-02-09 17:58 PST
,
Eric Seidel (no email)
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1
2012-02-09 17:58:58 PST
Created
attachment 126415
[details]
Patch
WebKit Review Bot
Comment 2
2012-02-09 22:18:28 PST
Comment on
attachment 126415
[details]
Patch Clearing flags on attachment: 126415 Committed
r107361
: <
http://trac.webkit.org/changeset/107361
>
WebKit Review Bot
Comment 3
2012-02-09 22:18:33 PST
All reviewed patches have been landed. Closing bug.
Dirk Pranke
Comment 4
2012-02-19 11:58:27 PST
Comment on
attachment 126415
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=126415&action=review
> Tools/Scripts/webkitpy/layout_tests/port/base.py:300 > + # FIXME: Seems we should get this from the Port's Driver class.
The reason this is here as a separate file is that there is no direct route to a Driver object; you have to actually create one; when this was first written, I thought creating a driver might actually launch a process and hence be a heavyweight operation. Things haven't turned out that way, so we could probably fix this in a straightforward manner.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug