Bug 78301 - Rename compare_text and compare_audio to make it clear that they're !=
Summary: Rename compare_text and compare_audio to make it clear that they're !=
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks: 71403
  Show dependency tree / graph
 
Reported: 2012-02-09 17:54 PST by Eric Seidel (no email)
Modified: 2012-02-19 11:58 PST (History)
3 users (show)

See Also:

Attachments
Patch (12.41 KB, patch)
2012-02-09 17:58 PST, Eric Seidel (no email) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2012-02-09 17:54:14 PST 
Rename compare_text and compare_audio to make it clear that they're !=
Comment 1 Eric Seidel (no email) 2012-02-09 17:58:58 PST 
Created attachment 126415 [details]
Patch
Comment 2 WebKit Review Bot 2012-02-09 22:18:28 PST 
Comment on attachment 126415 [details]
Patch

Clearing flags on attachment: 126415

Committed r107361: <http://trac.webkit.org/changeset/107361>
Comment 3 WebKit Review Bot 2012-02-09 22:18:33 PST 
All reviewed patches have been landed.  Closing bug.
Comment 4 Dirk Pranke 2012-02-19 11:58:27 PST 
Comment on attachment 126415 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=126415&action=review

> Tools/Scripts/webkitpy/layout_tests/port/base.py:300
> +        # FIXME: Seems we should get this from the Port's Driver class.

The reason this is here as a separate file is that there is no direct route to a Driver object; you have to actually create one; when this was first written, I thought creating a driver might actually launch a process and hence be a heavyweight operation. Things haven't turned out that way, so we could probably fix this in a straightforward manner.