Bug 78293 - Support cross-fade() of generated images (gradients, canvas, etc.)
Summary: Support cross-fade() of generated images (gradients, canvas, etc.)
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords: InRadar
: 79772 90828 (view as bug list)
Depends on:
Blocks:
 
Reported: 2012-02-09 16:16 PST by Tim Horton
Modified: 2023-05-28 23:38 PDT (History)
13 users (show)

See Also:


Attachments
extremely preliminary patch (30.18 KB, patch)
2012-02-09 16:16 PST, Tim Horton
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2012-02-09 16:16:13 PST
Created attachment 126400 [details]
extremely preliminary patch

We should support things like this:

background: -webkit-cross-fade(-webkit-cross-fade(-webkit-canvas(squares), -webkit-canvas(thirdsquares), 0.5), -webkit-canvas(othersquares), 0.5);

or this:

background: -webkit-cross-fade(-webkit-linear-gradient(red, blue), url("apple.gif"), 0.5);

<rdar://problem/10459872>
Comment 1 Tim Horton 2012-02-09 16:18:10 PST
I want to do some additional reorganization of CSSImageValue and co. to make this patch much smaller. Also, it still does some things I don't like. Still, it's a start! Also, it fixes animated-GIF-in-cross-fade, but I'll be splitting that out and attaching the (tiny) patch required to that bug.
Comment 2 WebKit Review Bot 2012-02-09 18:13:09 PST
Comment on attachment 126400 [details]
extremely preliminary patch

Attachment 126400 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11486469

New failing tests:
css3/images/cross-fade-tiled.html
animations/cross-fade-border-image-source.html
transitions/cross-fade-border-image.html
css3/images/cross-fade-simple.html
css3/images/cross-fade-invalidation.html
transitions/cross-fade-background-image.html
animations/cross-fade-list-style-image.html
animations/cross-fade-webkit-mask-image.html
css3/images/cross-fade-blending.html
css3/images/cross-fade-overflow-position.html
animations/cross-fade-webkit-mask-box-image.html
animations/cross-fade-background-image.html
css3/images/cross-fade-sizing.html
Comment 3 Shane Stephens 2012-02-29 19:28:18 PST
*** Bug 79772 has been marked as a duplicate of this bug. ***
Comment 4 Tim Horton 2013-02-22 19:10:45 PST
*** Bug 90828 has been marked as a duplicate of this bug. ***
Comment 5 Sam Weinig 2022-10-22 10:36:38 PDT
Once https://bugs.webkit.org/show_bug.cgi?id=246594 lands, this should be relatively straightforward to do. Taking this.