Bug 78291 - FrameView::addSlowRepaintObject() doesn't update m_canBlitOnScroll correctly
Summary: FrameView::addSlowRepaintObject() doesn't update m_canBlitOnScroll correctly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-09 15:29 PST by Anders Carlsson
Modified: 2012-02-09 17:55 PST (History)
0 users

See Also:


Attachments
Patch (1.76 KB, patch)
2012-02-09 15:32 PST, Anders Carlsson
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2012-02-09 15:29:25 PST
FrameView::addSlowRepaintObject() doesn't update m_canBlitOnScroll correctly
Comment 1 Anders Carlsson 2012-02-09 15:32:03 PST
Created attachment 126388 [details]
Patch
Comment 2 mitz 2012-02-09 15:38:38 PST
Comment on attachment 126388 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=126388&action=review

> Source/WebCore/page/FrameView.cpp:1332
>      m_slowRepaintObjectCount++;
> +    if (m_slowRepaintObjectCount == 1)

This is one case where I think collapsing this into a single line would have made things clearer:
    if (!m_slowRepaintObjectCount++)
Comment 3 Anders Carlsson 2012-02-09 17:55:00 PST
Committed r107332: <http://trac.webkit.org/changeset/107332>