Bug 78284 - Make WebGLRenderingContext::printWarningToConsole safer
Summary: Make WebGLRenderingContext::printWarningToConsole safer
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-09 14:40 PST by Gregg Tavares
Modified: 2012-02-09 21:59 PST (History)
2 users (show)

See Also:


Attachments
Patch (2.02 KB, patch)
2012-02-09 14:41 PST, Gregg Tavares
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gregg Tavares 2012-02-09 14:40:09 PST
Make WebGLRenderingContext::printWarningToConsole safer
Comment 1 Gregg Tavares 2012-02-09 14:41:00 PST
Created attachment 126375 [details]
Patch
Comment 2 Gregg Tavares 2012-02-09 14:41:51 PST
apparently some of these can go NULL causing a crash so I added checks.
Comment 3 Kenneth Russell 2012-02-09 14:43:57 PST
Comment on attachment 126375 [details]
Patch

Looks good.
Comment 4 WebKit Review Bot 2012-02-09 21:59:09 PST
Comment on attachment 126375 [details]
Patch

Clearing flags on attachment: 126375

Committed r107358: <http://trac.webkit.org/changeset/107358>
Comment 5 WebKit Review Bot 2012-02-09 21:59:13 PST
All reviewed patches have been landed.  Closing bug.