This bug track another step in the direction of removing access to NSPasteboard from the WebProcess. The Mac implementation of the Pasteboard class needs to be redesigned to use a platform strategy that can provide different implementations for WebKit and WebKit2.
Created attachment 126392 [details] patch
I rolled it out, because it broke the Qt build - http://trac.webkit.org/changeset/107475 ../../../Source/WebKit/qt/WebCoreSupport/PlatformStrategiesQt.cpp: In static member function 'static void PlatformStrategiesQt::initialize()': ../../../Source/WebKit/qt/WebCoreSupport/PlatformStrategiesQt.cpp:51: error: cannot allocate an object of abstract type 'PlatformStrategiesQt' ../../../Source/WebKit/qt/WebCoreSupport/PlatformStrategiesQt.h:41: note: because the following virtual functions are pure within 'PlatformStrategiesQt': ../../../Source/WebCore/platform/PlatformStrategies.h:95: note: virtual WebCore::PasteboardStrategy* WebCore::PlatformStrategies::createPasteboardStrategy() Next time please use EWS bots or watch the bots after landing to ensure that your patch builds on all platform. http://www.webkit.org/coding/contributing.html "Your change must at least compile on all platforms." Qt build was broken during ~70 revision because of this patch. :( It means that the test coverage was 0 in this time. And unfortunately somebody broke all JSC tests on Qt-debug during build breakage. It won't be a good game to find it manually ...
(In reply to comment #2) > I rolled it out, because it broke the Qt build - http://trac.webkit.org/changeset/107475 > > ../../../Source/WebKit/qt/WebCoreSupport/PlatformStrategiesQt.cpp: In static member function 'static void PlatformStrategiesQt::initialize()': > ../../../Source/WebKit/qt/WebCoreSupport/PlatformStrategiesQt.cpp:51: error: cannot allocate an object of abstract type 'PlatformStrategiesQt' > ../../../Source/WebKit/qt/WebCoreSupport/PlatformStrategiesQt.h:41: note: because the following virtual functions are pure within 'PlatformStrategiesQt': > ../../../Source/WebCore/platform/PlatformStrategies.h:95: note: virtual WebCore::PasteboardStrategy* WebCore::PlatformStrategies::createPasteboardStrategy() > > Next time please use EWS bots or watch the bots after landing to ensure that your patch builds on all platform. > > http://www.webkit.org/coding/contributing.html > "Your change must at least compile on all platforms." > > Qt build was broken during ~70 revision because of this patch. :( It means that the test coverage was 0 in this time. And unfortunately somebody broke all JSC tests on Qt-debug during build breakage. It won't be a good game to find it manually ... My apologies, I did not notice that the Qt port was using platform strategies. I will resubmit my patch with the build fix for Qt.
Created attachment 126819 [details] Patch to verify the Qt build fix
Attachment 126819 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/platform/PlatformPasteboard.h:53: The parameter name "string" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/platform/PasteboardStrategy.h:50: The parameter name "string" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebKit/mac/WebCoreSupport/WebPlatformStrategies.h:67: The parameter name "buffer" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebKit/mac/WebCoreSupport/WebPlatformStrategies.h:69: The parameter name "string" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebKit2/WebProcess/WebCoreSupport/WebPlatformStrategies.h:75: The parameter name "string" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/platform/Pasteboard.h:33: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 6 in 20 files If any of these errors are false positives, please file a bug against check-webkit-style.
http://trac.webkit.org/changeset/107606