Bug 78278 – [BlackBerry] Upstream graphics helper classes in WebKitSupport

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Rob Buis]

Upstream graphics helper classes in WebKitSupport

[Rob Buis]

Created attachment 126360 [details]
Patch

[Rob Buis]

Add Antonio.

[Antonio Gomes]

Comment on attachment 126360 [details]
Patch

you probably uploaded the wrong patch. WebPageCompositor is here: bug 78276

[Rob Buis]

Created attachment 126376 [details]
Patch

[Antonio Gomes]

jakob/adam, do we want to upstream #if OPENVG blocks of code, or stick with SKIA only?

[Jakob Petsovits]

I think we want to avoid upstreaming them, and suggest removal of OpenVG from the tree as it's not a focus for us anymore.

[Antonio Gomes]

Comment on attachment 126376 [details]
Patch

lets set us free of openvg first :-)

[Rob Buis]

Created attachment 126425 [details]
Patch

[Antonio Gomes]

Comment on attachment 126425 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=126425&action=review

some more comments and questions ...

> Source/WebKit/blackberry/WebKitSupport/SurfacePool.cpp:109
> +#if USE(SKIA)
> +    WebCore::PlatformContextSkia* platformGraphicsContext = new WebCore::PlatformContextSkia(drawable);
> +#endif
> +    return platformGraphicsContext;

that wont build if !SKIA

> Source/WebKit/blackberry/WebKitSupport/SurfacePool.cpp:119
> +PlatformGraphicsContext* SurfacePool::lockTileRenderingSurface() const
> +{
> +#if USE(SKIA)
> +    if (!m_tileRenderingSurface)
> +        return 0;
> +    return createPlatformGraphicsContext(BlackBerry::Platform::Graphics::lockBufferDrawable(m_tileRenderingSurface));
> +#endif
> +}

that wont return anything if !SKIA

> Source/WebKit/blackberry/WebKitSupport/SurfacePool.cpp:175
> +    // Create the m_visibleTileBuffer.

do we need these comment?

> Source/WebKit/blackberry/WebKitSupport/SurfacePool.cpp:199
> +    // Release the m_visibleTileBuffer.

ditto

> Source/WebKit/blackberry/WebKitSupport/SurfacePool.cpp:205
> +    // Release the backbuffer.

ditto

> Source/WebKit/blackberry/WebKitSupport/SurfacePool.h:87
> +#if USE(SKIA)

maybe we should just drop the SKIA condition completely?

[Rob Buis]

Created attachment 126513 [details]
Patch

[Rob Buis]

Landed in r107401.

[Rob Buis]

Reopening to attach new patch.

[Rob Buis]

Created attachment 126542 [details]
Patch

[Rob Buis]

Created attachment 126546 [details]
Patch

[Rob Buis]

Landed in r107426.