Bug 78271 - run-perf-tests should have an option to pause before running tests so we can attach Instruments
Summary: run-perf-tests should have an option to pause before running tests so we can ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-09 12:43 PST by Adam Barth
Modified: 2012-02-09 13:26 PST (History)
3 users (show)

See Also:

Attachments
Patch (9.13 KB, patch)
2012-02-09 12:44 PST, Adam Barth 		rniwa: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2012-02-09 12:43:55 PST 
run-perf-tests should have an option to pause before running tests so we can attach Instruments
Comment 1 Adam Barth 2012-02-09 12:44:36 PST 
Created attachment 126351 [details]
Patch
Comment 2 Ryosuke Niwa 2012-02-09 12:47:08 PST 
Comment on attachment 126351 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=126351&action=review

> Tools/Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:196
> +            self.assertEqual(stderr, "Ready to run test?\n")

It's strange that we use stderr for this
Comment 3 Adam Barth 2012-02-09 13:26:19 PST 
Yeah, we didn't understand logging when we started webkitpy.
Comment 4 Adam Barth 2012-02-09 13:26:39 PST 
Committed r107284: <http://trac.webkit.org/changeset/107284>