Bug 78259 – [chromium] skip tests affected by deprecation of in-url identities.

• Status: RESOLVED
• Resolution: FIXED
• Component: Page Loading

[Thomas Sepez]

The following tests will fail on chromium only once its HttpAuthController deprecates in-url identities.

http/tests/xmlhttprequest/basic-auth-default.html = TEXT
http/tests/xmlhttprequest/basic-auth-nopassword.html = TEXT
http/tests/xmlhttprequest/basic-auth-nouser.html = TEXT
http/tests/xmlhttprequest/cross-origin-authorization.html = TEXT
http/tests/xmlhttprequest/cross-origin-no-authorization.html = TEXT
http/tests/xmlhttprequest/re-login-async.html = TEXT
http/tests/xmlhttprequest/re-login.html = TEXT
http/tests/appcache/auth.html = TIMEOUT
http/tests/xmlhttprequest/basic-auth.html = TIMEOUT

[Thomas Sepez]

Created attachment 126339 [details]
Patch.

[WebKit Review Bot]

Attachment 126339 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1

LayoutTests/platform/chromium/test_expectations.txt:792:  More specific entry on line 792 overrides line 424 http/tests/security/credentials-in-referer.html  [test/expectations] [5]
LayoutTests/platform/chromium/test_expectations.txt:1599:  More specific entry on line 1599 overrides line 428 http/tests/xmlhttprequest/basic-auth.html  [test/expectations] [5]
LayoutTests/platform/chromium/test_expectations.txt:1600:  More specific entry on line 1600 overrides line 425 http/tests/xmlhttprequest/basic-auth-default.html  [test/expectations] [5]
LayoutTests/platform/chromium/test_expectations.txt:1644:  More specific entry on line 1644 overrides line 430 http/tests/xmlhttprequest/cross-origin-no-authorization.html  [test/expectations] [5]
LayoutTests/platform/chromium/test_expectations.txt:1823:  More specific entry on line 1823 overrides line 423 http/tests/appcache/auth.html  [test/expectations] [5]
Total errors found: 5 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Adam Barth]

Comment on attachment 126339 [details]
Patch.

The text_expectations.txt file needs to pass the lint check, which you can run locally using check-webkit-style.

[Thomas Sepez]

Created attachment 126342 [details]
Patch try 2

[Thomas Sepez]

(In reply to comment #3)
> (From update of attachment 126339 [details])
> The text_expectations.txt file needs to pass the lint check, which you can run locally using check-webkit-style.

Actuall, I did that, and it didn't complain.  Strange.

[WebKit Review Bot]

Comment on attachment 126342 [details]
Patch try 2

Clearing flags on attachment: 126342

Committed r107353: <http://trac.webkit.org/changeset/107353>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.