Bug 78259 - [chromium] skip tests affected by deprecation of in-url identities.
Summary: [chromium] skip tests affected by deprecation of in-url identities.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Thomas Sepez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-09 11:23 PST by Thomas Sepez
Modified: 2012-02-09 21:23 PST (History)
3 users (show)

See Also:


Attachments
Patch. (1.99 KB, patch)
2012-02-09 11:44 PST, Thomas Sepez
abarth: review-
Details | Formatted Diff | Diff
Patch try 2 (4.12 KB, patch)
2012-02-09 11:59 PST, Thomas Sepez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Sepez 2012-02-09 11:23:27 PST
The following tests will fail on chromium only once its HttpAuthController deprecates in-url identities.

http/tests/xmlhttprequest/basic-auth-default.html = TEXT
http/tests/xmlhttprequest/basic-auth-nopassword.html = TEXT
http/tests/xmlhttprequest/basic-auth-nouser.html = TEXT
http/tests/xmlhttprequest/cross-origin-authorization.html = TEXT
http/tests/xmlhttprequest/cross-origin-no-authorization.html = TEXT
http/tests/xmlhttprequest/re-login-async.html = TEXT
http/tests/xmlhttprequest/re-login.html = TEXT
http/tests/appcache/auth.html = TIMEOUT
http/tests/xmlhttprequest/basic-auth.html = TIMEOUT
Comment 1 Thomas Sepez 2012-02-09 11:44:00 PST
Created attachment 126339 [details]
Patch.
Comment 2 WebKit Review Bot 2012-02-09 11:47:47 PST
Attachment 126339 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1

LayoutTests/platform/chromium/test_expectations.txt:792:  More specific entry on line 792 overrides line 424 http/tests/security/credentials-in-referer.html  [test/expectations] [5]
LayoutTests/platform/chromium/test_expectations.txt:1599:  More specific entry on line 1599 overrides line 428 http/tests/xmlhttprequest/basic-auth.html  [test/expectations] [5]
LayoutTests/platform/chromium/test_expectations.txt:1600:  More specific entry on line 1600 overrides line 425 http/tests/xmlhttprequest/basic-auth-default.html  [test/expectations] [5]
LayoutTests/platform/chromium/test_expectations.txt:1644:  More specific entry on line 1644 overrides line 430 http/tests/xmlhttprequest/cross-origin-no-authorization.html  [test/expectations] [5]
LayoutTests/platform/chromium/test_expectations.txt:1823:  More specific entry on line 1823 overrides line 423 http/tests/appcache/auth.html  [test/expectations] [5]
Total errors found: 5 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Adam Barth 2012-02-09 11:53:23 PST
Comment on attachment 126339 [details]
Patch.

The text_expectations.txt file needs to pass the lint check, which you can run locally using check-webkit-style.
Comment 4 Thomas Sepez 2012-02-09 11:59:56 PST
Created attachment 126342 [details]
Patch try 2
Comment 5 Thomas Sepez 2012-02-09 12:01:47 PST
(In reply to comment #3)
> (From update of attachment 126339 [details])
> The text_expectations.txt file needs to pass the lint check, which you can run locally using check-webkit-style.

Actuall, I did that, and it didn't complain.  Strange.
Comment 6 WebKit Review Bot 2012-02-09 21:23:50 PST
Comment on attachment 126342 [details]
Patch try 2

Clearing flags on attachment: 126342

Committed r107353: <http://trac.webkit.org/changeset/107353>
Comment 7 WebKit Review Bot 2012-02-09 21:23:55 PST
All reviewed patches have been landed.  Closing bug.