Bug 78254 - Web Inspector: [refactoring] TimelineModel should not depend on TimelinePanel
Summary: Web Inspector: [refactoring] TimelineModel should not depend on TimelinePanel
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andrey Kosyakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-09 10:58 PST by Andrey Kosyakov
Modified: 2014-01-26 10:15 PST (History)
9 users (show)

See Also:

Attachments
Patch (7.52 KB, patch)
2012-02-09 23:31 PST, Andrey Kosyakov 		yurys: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Kosyakov 2012-02-09 10:58:07 PST 
This breaks cyclical dependency between TimelineModel and TimelinePanel by introducing EventRecorded and EventsCleared events dispatched by the timeline model.
Comment 1 Andrey Kosyakov 2012-02-09 23:31:34 PST 
Created attachment 126463 [details]
Patch
Comment 2 Yury Semikhatsky 2012-02-10 00:03:24 PST 
Comment on attachment 126463 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=126463&action=review

> Source/WebCore/inspector/front-end/TimelinePanel.js:1527
> +WebInspector.TimelineModel.Events = {

Please place this constant declarations right after the constructor.
Comment 3 Andrey Kosyakov 2012-02-10 00:06:28 PST 
Committed r107373: <http://trac.webkit.org/changeset/107373>
Comment 4 Csaba Osztrogonác 2012-02-10 01:02:49 PST 
Reopen, because it made a test fail on Qt: (maybe on other ports too)
http://build.webkit.sed.hu/results/x86-64%20Linux%20Qt%20Release/r107376%20%2833552%29/inspector/timeline/timeline-receive-response-event-pretty-diff.html