RESOLVED INVALID 78254
Web Inspector: [refactoring] TimelineModel should not depend on TimelinePanel 
https://bugs.webkit.org/show_bug.cgi?id=78254
Summary Web Inspector: [refactoring] TimelineModel should not depend on TimelinePanel
Andrey Kosyakov
Reported 2012-02-09 10:58:07 PST
This breaks cyclical dependency between TimelineModel and TimelinePanel by introducing EventRecorded and EventsCleared events dispatched by the timeline model.
Attachments
Patch (7.52 KB, patch)
2012-02-09 23:31 PST, Andrey Kosyakov 		yurys: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andrey Kosyakov
Comment 1 2012-02-09 23:31:34 PST
Created attachment 126463 [details] Patch
Yury Semikhatsky
Comment 2 2012-02-10 00:03:24 PST
Comment on attachment 126463 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=126463&action=review > Source/WebCore/inspector/front-end/TimelinePanel.js:1527 > +WebInspector.TimelineModel.Events = { Please place this constant declarations right after the constructor.
Andrey Kosyakov
Comment 3 2012-02-10 00:06:28 PST
Committed r107373: <http://trac.webkit.org/changeset/107373>
Csaba Osztrogonác
Comment 4 2012-02-10 01:02:49 PST
Reopen, because it made a test fail on Qt: (maybe on other ports too) http://build.webkit.sed.hu/results/x86-64%20Linux%20Qt%20Release/r107376%20%2833552%29/inspector/timeline/timeline-receive-response-event-pretty-diff.html
Note You need to log in before you can comment on or make changes to this bug.