Bug 78242 - Eliminate dead code in BytecodeGenerator::resolve()
Summary: Eliminate dead code in BytecodeGenerator::resolve()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andy Wingo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-09 08:05 PST by Andy Wingo
Modified: 2012-02-09 19:49 PST (History)
4 users (show)

See Also:


Attachments
Patch (2.02 KB, patch)
2012-02-09 08:07 PST, Andy Wingo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Wingo 2012-02-09 08:05:14 PST
BytecodeGenerator::shouldOptimizeLocals() is only true for FunctionCode, and thus cannot be true for GlobalCode.  This patch removes an impossible branch.
Comment 1 Andy Wingo 2012-02-09 08:07:53 PST
Created attachment 126308 [details]
Patch
Comment 2 WebKit Review Bot 2012-02-09 19:49:07 PST
Comment on attachment 126308 [details]
Patch

Clearing flags on attachment: 126308

Committed r107348: <http://trac.webkit.org/changeset/107348>
Comment 3 WebKit Review Bot 2012-02-09 19:49:11 PST
All reviewed patches have been landed.  Closing bug.