Bug 78238 - Style-checker doesn't complain about a style violation in a for statement without any initialization
Summary: Style-checker doesn't complain about a style violation in a for statement wit...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-09 07:33 PST by Julien Chaffraix
Modified: 2012-02-09 07:41 PST (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Julien Chaffraix 2012-02-09 07:33:08 PST 
Seen on bug 78027, the following statement passed the style queue and should not have:

for (;child && child->isTableCol(); child = child->nextCol())

Note that the first semi-colon should have a space after per our guidelines.
Comment 1 David Levin 2012-02-09 07:41:56 PST 
If you care about this fix:
I'm happy to review changes to the style checker and they aren't that hard to do as several folks have demonstrated.

I'm also happy to give guidance on how to do these changes too!

(But in general, I don't have time to address these issues -- especially missed checks.)

PS I'm surprised that the style checker didn't catch this. I would guess that this is an easy fix :).