RESOLVED FIXED Bug 78236
Web Inspector: [TextPrompt] TAB should complete suggestions up to their common prefix in Console 
https://bugs.webkit.org/show_bug.cgi?id=78236
Summary Web Inspector: [TextPrompt] TAB should complete suggestions up to their commo...
Alexander Pavlov (apavlov)
Reported 2012-02-09 07:19:26 PST
Patch to follow. Upstreaming http://code.google.com/p/chromium/issues/detail?id=112283
Attachments
Patch (4.05 KB, patch)
2012-02-09 07:45 PST, Alexander Pavlov (apavlov) 		vsevik: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexander Pavlov (apavlov)
Comment 1 2012-02-09 07:45:03 PST
Created attachment 126302 [details] Patch
Vsevolod Vlasov
Comment 2 2012-02-10 07:25:54 PST
Comment on attachment 126302 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=126302&action=review > Source/WebCore/inspector/front-end/TextPrompt.js:445 > + } Please extract this method. > Source/WebCore/inspector/front-end/TextPrompt.js:516 > + if (!this.autoCompleteElement || !this._commonPrefix || !this._userEnteredText || this._userEnteredText.length >= this._commonPrefix.length) We'd better check that user entered text is prefix of common prefix.
Alexander Pavlov (apavlov)
Comment 3 2012-02-10 07:42:02 PST
Committed r107402: <http://trac.webkit.org/changeset/107402>
Note You need to log in before you can comment on or make changes to this bug.