Bug 78236 - Web Inspector: [TextPrompt] TAB should complete suggestions up to their common prefix in Console
Summary: Web Inspector: [TextPrompt] TAB should complete suggestions up to their commo...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Alexander Pavlov (apavlov)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-09 07:19 PST by Alexander Pavlov (apavlov)
Modified: 2012-02-10 07:42 PST (History)
10 users (show)

See Also:

Attachments
Patch (4.05 KB, patch)
2012-02-09 07:45 PST, Alexander Pavlov (apavlov) 		vsevik: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Pavlov (apavlov) 2012-02-09 07:19:26 PST 
Patch to follow.

Upstreaming http://code.google.com/p/chromium/issues/detail?id=112283
Comment 1 Alexander Pavlov (apavlov) 2012-02-09 07:45:03 PST 
Created attachment 126302 [details]
Patch
Comment 2 Vsevolod Vlasov 2012-02-10 07:25:54 PST 
Comment on attachment 126302 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=126302&action=review

> Source/WebCore/inspector/front-end/TextPrompt.js:445
> +            }

Please extract this method.

> Source/WebCore/inspector/front-end/TextPrompt.js:516
> +        if (!this.autoCompleteElement || !this._commonPrefix || !this._userEnteredText || this._userEnteredText.length >= this._commonPrefix.length)

We'd better check that user entered text is prefix of common prefix.
Comment 3 Alexander Pavlov (apavlov) 2012-02-10 07:42:02 PST 
Committed r107402: <http://trac.webkit.org/changeset/107402>