Bug 78222 - Web Inspector: Timeline memory graph would have been more useful if it had used minUsedHeapSize as the lower bound. Currently it uses zero as the lower bound.
Summary: Web Inspector: Timeline memory graph would have been more useful if it had us...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Ilya Tikhonovsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-09 04:31 PST by Ilya Tikhonovsky
Modified: 2012-02-09 05:04 PST (History)
10 users (show)

See Also:


Attachments
screenshot (39.96 KB, image/png)
2012-02-09 04:38 PST, Ilya Tikhonovsky
no flags Details
Patch (4.93 KB, patch)
2012-02-09 04:42 PST, Ilya Tikhonovsky
no flags Details | Formatted Diff | Diff
Patch (4.86 KB, patch)
2012-02-09 04:58 PST, Ilya Tikhonovsky
pfeldman: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ilya Tikhonovsky 2012-02-09 04:31:29 PST
%subj%
Comment 1 Ilya Tikhonovsky 2012-02-09 04:38:11 PST
Created attachment 126280 [details]
screenshot
Comment 2 Ilya Tikhonovsky 2012-02-09 04:42:03 PST
Created attachment 126281 [details]
Patch
Comment 3 Pavel Feldman 2012-02-09 04:45:47 PST
Comment on attachment 126281 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=126281&action=review

> Source/WebCore/inspector/front-end/TimelineOverviewPane.js:582
> +        var delta = (maxUsedHeapSize - minUsedHeapSize) * 0.05;

Why not to shift the entire graph 5px?
Comment 4 Ilya Tikhonovsky 2012-02-09 04:58:54 PST
Created attachment 126283 [details]
Patch
Comment 5 Ilya Tikhonovsky 2012-02-09 05:04:33 PST
Committed r107223: <http://trac.webkit.org/changeset/107223>