WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 78211
[GTK] EWS command-line option to run the tests
https://bugs.webkit.org/show_bug.cgi?id=78211
Summary
[GTK] EWS command-line option to run the tests
Philippe Normand
Reported
2012-02-09 00:19:37 PST
I'm not sure all the 3 EWS GTK bots can run all the tests for each patch fast enough. That's why I'd like to add a new command-line switch so each bot can choose to opt-in if it can run the tests fast :) The igalia-gtk-ews should at least be able to do this. Will attach a patch.
Attachments
Patch
(4.18 KB, patch)
2012-02-09 04:06 PST
,
Philippe Normand
abarth
: review+
abarth
: commit-queue-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Gustavo Noronha (kov)
Comment 1
2012-02-09 03:52:38 PST
Sounds like a great idea =) my local EWS is probably able to keep up, not so sure about the collabora one for now, so having the switch would be good.
Philippe Normand
Comment 2
2012-02-09 04:06:28 PST
Created
attachment 126276
[details]
Patch
Adam Barth
Comment 3
2012-02-09 10:40:50 PST
Comment on
attachment 126276
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=126276&action=review
> Tools/Scripts/webkitpy/tool/commands/earlywarningsystem.py:48 > + options = [make_option("--run-tests", action="store_true", dest="tests", default=self._default_run_tests, help="Run the Layout tests for each patch")]
Can we name this run_tests ? We generally like to make the names in the code match the command line names.
Philippe Normand
Comment 4
2012-02-10 00:07:51 PST
Committed
r107374
: <
http://trac.webkit.org/changeset/107374
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug