Bug 78209 - Perf-o-matic should update memcache in taskqueue
Summary: Perf-o-matic should update memcache in taskqueue
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Website (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks: 77037
  Show dependency treegraph
 
Reported: 2012-02-09 00:14 PST by Ryosuke Niwa
Modified: 2012-02-09 12:20 PST (History)
2 users (show)

See Also:


Attachments
Fixes the bug (16.88 KB, patch)
2012-02-09 00:24 PST, Ryosuke Niwa
abarth: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2012-02-09 00:14:45 PST
webkit-perf.appspot.com takes forever to load right now because we update manifest, dashboard, etc... on demand. It creates memcache on demand but we should be doing in taskqueue instead.
Comment 1 Ryosuke Niwa 2012-02-09 00:24:23 PST
Created attachment 126251 [details]
Fixes the bug
Comment 2 Ryosuke Niwa 2012-02-09 00:33:43 PST
FWIW, I've already pushed this version to webkit-perf.appspot.com.
Comment 3 Adam Barth 2012-02-09 11:49:22 PST
Comment on attachment 126251 [details]
Fixes the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=126251&action=review

> Websites/webkit-perf.appspot.com/controller.py:47
> +        self.response.headers['Content-Type'] = 'application/json; charset=utf-8'

You shouldn't need a charset parameter for application/json.  It's always UTF-8.  charset parameters are only for text/... MIME types.

> Websites/webkit-perf.appspot.com/controller.py:65
> +        self.response.headers['Content-Type'] = 'application/json; charset=utf-8'

ditto

> Websites/webkit-perf.appspot.com/controller.py:83
> +        self.response.headers['Content-Type'] = 'application/json; charset=utf-8'

ditto
Comment 4 Ryosuke Niwa 2012-02-09 11:53:50 PST
Comment on attachment 126251 [details]
Fixes the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=126251&action=review

>> Websites/webkit-perf.appspot.com/controller.py:47
>> +        self.response.headers['Content-Type'] = 'application/json; charset=utf-8'
> 
> You shouldn't need a charset parameter for application/json.  It's always UTF-8.  charset parameters are only for text/... MIME types.

I see. Will fix.
Comment 5 Ryosuke Niwa 2012-02-09 12:20:45 PST
Committed r107274: <http://trac.webkit.org/changeset/107274>