We found that ExceptionCode is checked without initializing. Sometimes ExceptionCode is used without initializing, but it occasionally 'initialized' as 0. We would like to ensure that "if (ec) {...}" fails if ExceptionCode is not initialized as 0.
Created attachment 126224 [details] W.I.P.
Created attachment 126229 [details] W.I.P.
Created attachment 126232 [details] Patch
Comment on attachment 126232 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=126232&action=review Thanks for taking this. Our current version is error prone... > Source/WebCore/dom/ExceptionCodePlaceholder.h:44 > + ExceptionCodePlaceholder() : m_code(defaultExceptionCode) { } Please do this for NoExceptionAssertionChecker to keep ExceptionCodePlacerHolder code-free.
(In reply to comment #4) > (From update of attachment 126232 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=126232&action=review > > Thanks for taking this. Our current version is error prone... > > > Source/WebCore/dom/ExceptionCodePlaceholder.h:44 > > + ExceptionCodePlaceholder() : m_code(defaultExceptionCode) { } > > Please do this for NoExceptionAssertionChecker to keep ExceptionCodePlacerHolder code-free. Ya, this code seems wrong, because NoExceptionAssertionChecker initializes ExceptionCode with zero. We should change this value... Let me try again.
I was feeling weird that no error was found by this change...
Created attachment 126235 [details] Patch
Comment on attachment 126235 [details] Patch Clearing flags on attachment: 126235 Committed r107208: <http://trac.webkit.org/changeset/107208>
All reviewed patches have been landed. Closing bug.