RESOLVED FIXED Bug 78187
merge message_broker.py into manager_worker_broker.py 
https://bugs.webkit.org/show_bug.cgi?id=78187
Summary merge message_broker.py into manager_worker_broker.py
Dirk Pranke
Reported 2012-02-08 17:40:22 PST
merge message_broker.py into manager_worker_broker.py
Attachments
Patch (28.54 KB, patch)
2012-02-08 17:42 PST, Dirk Pranke 		no flags
DetailsFormatted DiffDiff
merge to r107844 + patch in bug 78181 (29.86 KB, patch)
2012-02-15 23:15 PST, Dirk Pranke 		no flags
DetailsFormatted DiffDiff
diff from r107844 w/o 78181's change (33.94 KB, patch)
2012-02-16 15:39 PST, Dirk Pranke 		no flags
DetailsFormatted DiffDiff
merge to r108005 (after fix to bug 78181) (28.70 KB, patch)
2012-02-16 17:15 PST, Dirk Pranke 		no flags
DetailsFormatted DiffDiff
merge to r108177 (28.66 KB, patch)
2012-02-18 16:59 PST, Dirk Pranke 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Dirk Pranke
Comment 1 2012-02-08 17:42:12 PST
Created attachment 126205 [details] Patch
Dirk Pranke
Comment 2 2012-02-15 23:15:42 PST
Created attachment 127316 [details] merge to r107844 + patch in bug 78181
Dirk Pranke
Comment 3 2012-02-15 23:25:09 PST
Tony, can you take a look at this, too? (hopefully the last one for a little while)
Tony Chang
Comment 4 2012-02-16 15:32:10 PST
Comment on attachment 127316 [details] merge to r107844 + patch in bug 78181 Can you rebase to ToT and upload? I want to see the side by side diff.
Dirk Pranke
Comment 5 2012-02-16 15:39:58 PST
Created attachment 127458 [details] diff from r107844 w/o 78181's change
Dirk Pranke
Comment 6 2012-02-16 15:41:06 PST
I've updated the description of the second attachment, and added a third. I'm not sure what definition of ToT you're looking for, but it should be (more or less) one of those two?
Tony Chang
Comment 7 2012-02-16 15:49:23 PST
(In reply to comment #6) > I've updated the description of the second attachment, and added a third. I'm not sure what definition of ToT you're looking for, but it should be (more or less) one of those two? Can you land the patch in bug 78181 then upload a clean diff against ToT? I want to use the side-by-side feature of the patch review tool because it's hard to tell what's an indention change vs a move. I guess you could also split that into two patches.
Dirk Pranke
Comment 8 2012-02-16 16:47:23 PST
(In reply to comment #7) > Can you land the patch in bug 78181 then upload a clean diff against ToT? Ah, sure ... will post shortly.
Dirk Pranke
Comment 9 2012-02-16 17:15:29 PST
Created attachment 127476 [details] merge to r108005 (after fix to bug 78181)
Dirk Pranke
Comment 10 2012-02-16 17:16:43 PST
Please take another look when you get a chance? (no hurry).
Dirk Pranke
Comment 11 2012-02-18 16:59:57 PST
Created attachment 127721 [details] merge to r108177
Dirk Pranke
Comment 12 2012-02-19 13:53:23 PST
Comment on attachment 127721 [details] merge to r108177 cancelling review - I've broken this patch up into three separate patches so hopefully it'll be easier to review.
Dirk Pranke
Comment 13 2012-02-24 20:11:36 PST
closing - the sub-bugs are closed.
Note You need to log in before you can comment on or make changes to this bug.