Bug 78179 - version_check.py should inform users that we don't support Python 2.5 anymore
Summary: version_check.py should inform users that we don't support Python 2.5 anymore
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-08 16:41 PST by Adam Barth
Modified: 2012-02-08 17:08 PST (History)
4 users (show)

See Also:


Attachments
Patch (1.28 KB, patch)
2012-02-08 16:44 PST, Adam Barth
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2012-02-08 16:41:48 PST
version_check.py should inform users that we don't support Python 2.5 anymore
Comment 1 Adam Barth 2012-02-08 16:44:24 PST
Created attachment 126187 [details]
Patch
Comment 2 Eric Seidel (no email) 2012-02-08 16:45:01 PST
Comment on attachment 126187 [details]
Patch

Does this have unittests we need to update?
Comment 3 Adam Barth 2012-02-08 16:46:16 PST
Committed r107155: <http://trac.webkit.org/changeset/107155>
Comment 4 Adam Barth 2012-02-08 16:50:22 PST
Not that I found.
Comment 5 Dirk Pranke 2012-02-08 17:08:44 PST
(In reply to comment #2)
> (From update of attachment 126187 [details])
> Does this have unittests we need to update?

No. When I wrote this, I argued that the code was too simple to write and too hard to test to be worth unit-testing, and I still think that that's true :).