Bug 78174 - [PerformanceTests] sunspider-crypto-md5.html and sunspider-crypto-sha1.html are timing out on cr-mac perf bot
Summary: [PerformanceTests] sunspider-crypto-md5.html and sunspider-crypto-sha1.html a...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hajime Morrita
URL:
Keywords:
Depends on:
Blocks: 77037
  Show dependency treegraph
 
Reported: 2012-02-08 16:11 PST by Ryosuke Niwa
Modified: 2012-02-08 23:14 PST (History)
4 users (show)

See Also:


Attachments
Patch (18.33 KB, patch)
2012-02-08 17:49 PST, Hajime Morrita
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Hajime Morrita 2012-02-08 16:30:11 PST
These tests are distributed under BSD-license:

/*
 * A JavaScript implementation of the Secure Hash Algorithm, SHA-1, as defined
 * in FIPS PUB 180-1
 * Version 2.1a Copyright Paul Johnston 2000 - 2002.
 * Other contributors: Greg Holt, Andrew Kepert, Ydnar, Lostinet
 * Distributed under the BSD License
 * See http://pajhome.org.uk/crypt/md5 for details.
 */

But on the other hand, we already have Sunspier under PerformanceTests/SunSpider.
So I guess it's OK to have them, especially WebKit binary doesn't contains them at all.
I'll pull them back.
Comment 2 Ryosuke Niwa 2012-02-08 16:39:37 PST
(In reply to comment #1)
> These tests are distributed under BSD-license:
> 
> /*
>  * A JavaScript implementation of the Secure Hash Algorithm, SHA-1, as defined
>  * in FIPS PUB 180-1
>  * Version 2.1a Copyright Paul Johnston 2000 - 2002.
>  * Other contributors: Greg Holt, Andrew Kepert, Ydnar, Lostinet
>  * Distributed under the BSD License
>  * See http://pajhome.org.uk/crypt/md5 for details.
>  */
> 
> But on the other hand, we already have Sunspier under PerformanceTests/SunSpider.
> So I guess it's OK to have them, especially WebKit binary doesn't contains them at all.
> I'll pull them back.

Okay. Btw, can we just share SunSpider .js files instead of having an extra copy inside Dromaeo/resources?
Comment 3 Hajime Morrita 2012-02-08 16:59:24 PST
(In reply to comment #2)
> Okay. Btw, can we just share SunSpider .js files instead of having an extra copy inside Dromaeo/resources?
Not automatically. It appends a boilerplate html round these JS files. 
I think we can just keep it as is, especially because there are several version of SunSupider.
Comment 4 Hajime Morrita 2012-02-08 17:49:08 PST
Created attachment 126207 [details]
Patch
Comment 5 WebKit Review Bot 2012-02-08 23:14:39 PST
Comment on attachment 126207 [details]
Patch

Clearing flags on attachment: 126207

Committed r107184: <http://trac.webkit.org/changeset/107184>
Comment 6 WebKit Review Bot 2012-02-08 23:14:44 PST
All reviewed patches have been landed.  Closing bug.