Bug 78174 – [PerformanceTests] sunspider-crypto-md5.html and sunspider-crypto-sha1.html are timing out on cr-mac perf bot

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Ryosuke Niwa]

See http://build.webkit.org/builders/Chromium%20Mac%20Release%20%28Perf%29/builds/238/steps/perf-test/logs/stdio

[Hajime Morrita]

These tests are distributed under BSD-license:

/*
 * A JavaScript implementation of the Secure Hash Algorithm, SHA-1, as defined
 * in FIPS PUB 180-1
 * Version 2.1a Copyright Paul Johnston 2000 - 2002.
 * Other contributors: Greg Holt, Andrew Kepert, Ydnar, Lostinet
 * Distributed under the BSD License
 * See http://pajhome.org.uk/crypt/md5 for details.
 */

But on the other hand, we already have Sunspier under PerformanceTests/SunSpider.
So I guess it's OK to have them, especially WebKit binary doesn't contains them at all.
I'll pull them back.

[Ryosuke Niwa]

(In reply to comment #1)
> These tests are distributed under BSD-license:
> 
> /*
>  * A JavaScript implementation of the Secure Hash Algorithm, SHA-1, as defined
>  * in FIPS PUB 180-1
>  * Version 2.1a Copyright Paul Johnston 2000 - 2002.
>  * Other contributors: Greg Holt, Andrew Kepert, Ydnar, Lostinet
>  * Distributed under the BSD License
>  * See http://pajhome.org.uk/crypt/md5 for details.
>  */
> 
> But on the other hand, we already have Sunspier under PerformanceTests/SunSpider.
> So I guess it's OK to have them, especially WebKit binary doesn't contains them at all.
> I'll pull them back.

Okay. Btw, can we just share SunSpider .js files instead of having an extra copy inside Dromaeo/resources?

[Hajime Morrita]

(In reply to comment #2)
> Okay. Btw, can we just share SunSpider .js files instead of having an extra copy inside Dromaeo/resources?
Not automatically. It appends a boilerplate html round these JS files. 
I think we can just keep it as is, especially because there are several version of SunSupider.

[Hajime Morrita]

Created attachment 126207 [details]
Patch

[WebKit Review Bot]

Comment on attachment 126207 [details]
Patch

Clearing flags on attachment: 126207

Committed r107184: <http://trac.webkit.org/changeset/107184>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.