Bug 78168 – nrwt: run_webkit_tests_integrationtest.py depends on being able to share a port w/ between master and worker

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Dirk Pranke]

Some of the integration tests in run_webkit_tests_integrationtest.py depend on being able to pass data back and forth in shared memory between 'manager' and 'worker'; this only happens to work when we have inline workers, and this causes complications in the manager_worker_broker interface (because we need to pass the shared host and port back and forth).

These tests should be rewritten to either be true unit tests or to be proper black-box integration tests that don't rely on custom ports.

[Dirk Pranke]

Created attachment 177853 [details]
Patch

[Dirk Pranke]

Note that the original problem in the description was that we had to jump through some hoops in the message_pool (nee manager_worker_broker) classes in order to pass the shared port across; this was fixed some time ago by proper use of MockHosts and propagating the host across. 

However, the test code was still ugly as a result of the faking/overriding going on, so this makes things (IMO) quite a bit cleaner and clearer.

[WebKit Review Bot]

Attachment 177853 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/webkitpy..." exit_code: 1
Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:155:  [get_test_results] Passing unexpected keyword argument 'logging_stream' in function call  [pylint/E1123] [5]
Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:160:  [get_test_results] Instance of 'int' has no 'result_summary' member (but some types could not be inferred)  [pylint/E1103] [5]
Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:161:  [get_test_results] Instance of 'int' has no 'result_summary' member (but some types could not be inferred)  [pylint/E1103] [5]
Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:163:  [get_test_results] Instance of 'int' has no 'retry_summary' member (but some types could not be inferred)  [pylint/E1103] [5]
Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:164:  [get_test_results] Instance of 'int' has no 'retry_summary' member (but some types could not be inferred)  [pylint/E1103] [5]
Total errors found: 5 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[kov's GTK+ EWS bot]

Comment on attachment 177853 [details]
Patch

Attachment 177853 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/15158485

[Dirk Pranke]

I think the style failures are due to the style bot being behind; the code is correct and check-webkit-style runs cleanly on my machine. I've filed bug 104190 for that.

[Dirk Pranke]

Committed r136780: <http://trac.webkit.org/changeset/136780>