RESOLVED FIXED 78166
[chromium] Add method to WebPluginContainer to check if a rectangle is topmost 
https://bugs.webkit.org/show_bug.cgi?id=78166
Summary [chromium] Add method to WebPluginContainer to check if a rectangle is topmost
Viet-Trung Luu
Reported 2012-02-08 15:34:49 PST
[chromium] Add method to WebPluginContainer to check if a rectangle is topmost
Attachments
Patch (3.87 KB, patch)
2012-02-08 15:41 PST, Viet-Trung Luu 		no flags
DetailsFormatted DiffDiff
Patch (3.86 KB, patch)
2012-02-16 10:10 PST, Viet-Trung Luu 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Viet-Trung Luu
Comment 1 2012-02-08 15:41:20 PST
Created attachment 126168 [details] Patch
Viet-Trung Luu
Comment 2 2012-02-08 15:42:18 PST
This is needed by Pepper Flash to ensure that the "Flash dialogs" aren't covered by anything.
WebKit Review Bot
Comment 3 2012-02-08 15:43:37 PST
Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API.
Viet-Trung Luu
Comment 4 2012-02-14 10:26:13 PST
@fishd - ping
Darin Fisher (:fishd, Google)
Comment 5 2012-02-14 16:45:58 PST
Comment on attachment 126168 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=126168&action=review > Source/WebKit/chromium/src/WebPluginContainerImpl.cpp:438 > +bool WebPluginContainerImpl::isRectTopmost(const WebRect& rect) I think it would probably be better from an API point of view to instead add a WebView::hitTestAtPoint method. You might also add a method to map plugin coordinates to window coordinates.
Darin Fisher (:fishd, Google)
Comment 6 2012-02-15 12:45:34 PST
Trung and I discussed this, and it looks like hit testing is not so simple to generalize.
WebKit Review Bot
Comment 7 2012-02-15 13:43:17 PST
Comment on attachment 126168 [details] Patch Rejecting attachment 126168 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: --chromium', '--force-update']" exit_code: 2 Updating OpenSource git.webkit.org[0: 17.254.20.231]: errno=Connection refused fatal: unable to connect a socket (Connection refused) Died at Tools/Scripts/update-webkit line 162. Failed to run "['Tools/Scripts/update-webkit', '--chromium', '--force-update']" exit_code: 2 Updating OpenSource git.webkit.org[0: 17.254.20.231]: errno=Connection refused fatal: unable to connect a socket (Connection refused) Died at Tools/Scripts/update-webkit line 162. Full output: http://queues.webkit.org/results/11531284
Viet-Trung Luu
Comment 8 2012-02-16 10:10:34 PST
Created attachment 127401 [details] Patch
WebKit Review Bot
Comment 9 2012-02-16 11:36:45 PST
Comment on attachment 127401 [details] Patch Clearing flags on attachment: 127401 Committed r107960: <http://trac.webkit.org/changeset/107960>
WebKit Review Bot
Comment 10 2012-02-16 11:36:51 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.