Bug 78164 - Remove simplejson because it's no longer used by webkitpy
Summary: Remove simplejson because it's no longer used by webkitpy
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks: 71593
  Show dependency treegraph
 
Reported: 2012-02-08 15:28 PST by Adam Barth
Modified: 2012-02-20 20:13 PST (History)
2 users (show)

See Also:


Attachments
Patch (152.05 KB, patch)
2012-02-08 15:29 PST, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2012-02-08 15:28:53 PST
Remove simplejson because it's no longer used by webkitpy
Comment 1 Adam Barth 2012-02-08 15:29:31 PST
Created attachment 126164 [details]
Patch
Comment 2 Adam Barth 2012-02-08 15:35:33 PST
Committed r107141: <http://trac.webkit.org/changeset/107141>
Comment 3 Csaba Osztrogonác 2012-02-20 08:14:48 PST
(In reply to comment #2)
> Committed r107141: <http://trac.webkit.org/changeset/107141>

Reopen, because this change broke the unittest of master.cfg:
File "./mastercfg_unittest.py", line 31, in _add_dependant_modules_to_sys_modules
    from webkitpy.thirdparty import simplejson
ImportError: cannot import name simplejson

Should we revert this change?
Comment 4 Adam Barth 2012-02-20 19:55:52 PST
Nope.

mastercfg_unittest should be changed to just import the built-in version of json.
Comment 5 Adam Barth 2012-02-20 20:13:37 PST
Fix for test in https://bugs.webkit.org/show_bug.cgi?id=79070