WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
78164
Remove simplejson because it's no longer used by webkitpy
https://bugs.webkit.org/show_bug.cgi?id=78164
Summary
Remove simplejson because it's no longer used by webkitpy
Adam Barth
Reported
2012-02-08 15:28:53 PST
Remove simplejson because it's no longer used by webkitpy
Attachments
Patch
(152.05 KB, patch)
2012-02-08 15:29 PST
,
Adam Barth
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Adam Barth
Comment 1
2012-02-08 15:29:31 PST
Created
attachment 126164
[details]
Patch
Adam Barth
Comment 2
2012-02-08 15:35:33 PST
Committed
r107141
: <
http://trac.webkit.org/changeset/107141
>
Csaba Osztrogonác
Comment 3
2012-02-20 08:14:48 PST
(In reply to
comment #2
)
> Committed
r107141
: <
http://trac.webkit.org/changeset/107141
>
Reopen, because this change broke the unittest of master.cfg: File "./mastercfg_unittest.py", line 31, in _add_dependant_modules_to_sys_modules from webkitpy.thirdparty import simplejson ImportError: cannot import name simplejson Should we revert this change?
Adam Barth
Comment 4
2012-02-20 19:55:52 PST
Nope. mastercfg_unittest should be changed to just import the built-in version of json.
Adam Barth
Comment 5
2012-02-20 20:13:37 PST
Fix for test in
https://bugs.webkit.org/show_bug.cgi?id=79070
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug