Bug 78125 – r107042 caused compile breakages on chromium try bots

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Pavel Podivilov]

--------------------Configuration: webkit_platform - Release|Win32-------------
Compiling...
WebFloatQuad.cpp
e:\b\build\slave\win\build\src\third_party\webkit\source\platform\chromium\public\WebFloatPoint.h(37) : fatal error C1083: Cannot open include file: 'FloatPoint.h': No such file or directory
WebCString.cpp
WebString.cpp
Copying WebCore headers needed by Platform API

webkit_platform - 1 error(s), 0 warning(s)

[Pavel Podivilov]

Looks like platform_api_copy_webcore_headers action added in http://trac.webkit.org/changeset/107042 is sometimes performed in parallel with compiling sources:

--------------------Configuration: webkit_platform - Release|Win32-------------
Compiling...
WebFloatQuad.cpp
e:\b\build\slave\win\build\src\third_party\webkit\source\platform\chromium\public\WebFloatPoint.h(37) : fatal error C1083: Cannot open include file: 'FloatPoint.h': No such file or directory
WebCString.cpp
WebString.cpp
Copying WebCore headers needed by Platform API

webkit_platform - 1 error(s), 0 warning(s)

[James Robinson]

Created attachment 126124 [details]
Patch

[Adam Barth]

Comment on attachment 126124 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=126124&action=review

> Source/Platform/Platform.gyp/Platform.gyp:91
> +                    'destination': '<(output_dir)',

Not SHARED_INTERMEDIATE_DIR ?

[James Robinson]

output_dir is <(SHARED_INTERMEDIATE_DIR)/webcore_headers - see the variables section

[Adam Barth]

Comment on attachment 126124 [details]
Patch

r=me

[James Robinson]

Committed r107110: <http://trac.webkit.org/changeset/107110>