Bug 78125 - r107042 caused compile breakages on chromium try bots
Summary: r107042 caused compile breakages on chromium try bots
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: James Robinson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-08 09:52 PST by Pavel Podivilov
Modified: 2012-02-08 11:30 PST (History)
2 users (show)

See Also:


Attachments
Patch (4.36 KB, patch)
2012-02-08 11:19 PST, James Robinson
tony: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Podivilov 2012-02-08 09:52:42 PST
--------------------Configuration: webkit_platform - Release|Win32-------------
Compiling...
WebFloatQuad.cpp
e:\b\build\slave\win\build\src\third_party\webkit\source\platform\chromium\public\WebFloatPoint.h(37) : fatal error C1083: Cannot open include file: 'FloatPoint.h': No such file or directory
WebCString.cpp
WebString.cpp
Copying WebCore headers needed by Platform API

webkit_platform - 1 error(s), 0 warning(s)
Comment 1 Pavel Podivilov 2012-02-08 09:53:12 PST
Looks like platform_api_copy_webcore_headers action added in http://trac.webkit.org/changeset/107042 is sometimes performed in parallel with compiling sources:

--------------------Configuration: webkit_platform - Release|Win32-------------
Compiling...
WebFloatQuad.cpp
e:\b\build\slave\win\build\src\third_party\webkit\source\platform\chromium\public\WebFloatPoint.h(37) : fatal error C1083: Cannot open include file: 'FloatPoint.h': No such file or directory
WebCString.cpp
WebString.cpp
Copying WebCore headers needed by Platform API

webkit_platform - 1 error(s), 0 warning(s)
Comment 2 James Robinson 2012-02-08 11:19:44 PST
Created attachment 126124 [details]
Patch
Comment 3 Adam Barth 2012-02-08 11:24:01 PST
Comment on attachment 126124 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=126124&action=review

> Source/Platform/Platform.gyp/Platform.gyp:91
> +                    'destination': '<(output_dir)',

Not SHARED_INTERMEDIATE_DIR ?
Comment 4 James Robinson 2012-02-08 11:24:32 PST
output_dir is <(SHARED_INTERMEDIATE_DIR)/webcore_headers - see the variables section
Comment 5 Adam Barth 2012-02-08 11:28:30 PST
Comment on attachment 126124 [details]
Patch

r=me
Comment 6 James Robinson 2012-02-08 11:30:11 PST
Committed r107110: <http://trac.webkit.org/changeset/107110>